Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-17 12:03:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

remove redundant editing (#1116)

Browse Source 
* remove redundant editing

* update docs
This commit is contained in:
Gus Caplan
2017-01-19 11:11:24 -06:00
committed by Amish Shah
parent 1e6abe587b
commit 0300601649
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/client/rest/RESTMethods.js
View File

@@ -323,8 +323,9 @@ class RESTMethods {
); );
} }
createGuildRole(guild) { createGuildRole(guild, data) {
return this.rest.makeRequest('post', Constants.Endpoints.guildRoles(guild.id), true).then(role => if (data.color) data.color = this.client.resolver.resolveColor(data.color);
return this.rest.makeRequest('post', Constants.Endpoints.guildRoles(guild.id), true, data).then(role =>
this.client.actions.GuildRoleCreate.handle({ this.client.actions.GuildRoleCreate.handle({
guild_id: guild.id, guild_id: guild.id,
role, role,

15
src/structures/Guild.js
View File

@@ -608,7 +608,7 @@ class Guild {
} }
/** /**
* Creates a new role in the guild, and optionally updates it with the given information. * Creates a new role in the guild with given information
* @param {RoleData} [data] The data to update the role with * @param {RoleData} [data] The data to update the role with
* @returns {Promise<Role>} * @returns {Promise<Role>}
* @example * @example
@@ -618,14 +618,15 @@ class Guild {
* .catch(console.error); * .catch(console.error);
* @example * @example
* // create a new role with data * // create a new role with data
* guild.createRole({ name: 'Super Cool People' }) * guild.createRole({
* .then(role => console.log(`Created role ${role}`)) * name: 'Super Cool People',
* .catch(console.error) * color: 'BLUE',
* })
* .then(role => console.log(`Created role ${role}`))
* .catch(console.error)
*/ */
createRole(data) { createRole(data) {
const create = this.client.rest.methods.createGuildRole(this); return this.client.rest.methods.createGuildRole(this, data);
if (!data) return create;
return create.then(role => role.edit(data));
} }
/** /**