From 032d6613f730d5ec596f3789804e6ec621f31029 Mon Sep 17 00:00:00 2001 From: Gus Caplan Date: Sun, 11 Sep 2016 20:28:17 -0500 Subject: [PATCH] add a message, because WHY THE HELL DID NO ONE EVER DO THIS (#690) * add a message, because WHY THE HELL DID NO ONE EVER DO THIS !!! * make message better * make linter happy * disable max-len rule for line 37 * make gawdl3y be happy * gawdl3y triggers me * Update FfmpegConverterEngine.js --- src/client/voice/pcm/FfmpegConverterEngine.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/client/voice/pcm/FfmpegConverterEngine.js b/src/client/voice/pcm/FfmpegConverterEngine.js index 4875aca9e..ab03e2986 100644 --- a/src/client/voice/pcm/FfmpegConverterEngine.js +++ b/src/client/voice/pcm/FfmpegConverterEngine.js @@ -34,7 +34,10 @@ function chooseCommand() { for (const cmd of ['ffmpeg', 'avconv', './ffmpeg', './avconv']) { if (!ChildProcess.spawnSync(cmd, ['-h']).error) return cmd; } - return null; + throw new Error( + 'FFMPEG was not found on your system, so audio cannot be played.' + + 'Please make sure FFMPEG is installed and in your PATH' + ); } module.exports = FfmpegConverterEngine;