From 0adfc0fe951268c58b5a2c6f6ddc9fb0667e30f4 Mon Sep 17 00:00:00 2001 From: Tain101 Date: Tue, 30 Aug 2016 19:40:29 -0400 Subject: [PATCH] Fixed manageRoles bug in lib. Fixes #507 (#570) * ChannelPermissions changed manageRoles to administrator. fixes #507 * fixed manageRoles bug inside lib/ChannelPermissions. fixes #507 fixed related comments inside Role. --- lib/Structures/ChannelPermissions.js | 4 ++-- lib/Structures/Role.js | 2 +- src/Structures/Role.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/Structures/ChannelPermissions.js b/lib/Structures/ChannelPermissions.js index 046064d2e..a31c9548a 100644 --- a/lib/Structures/ChannelPermissions.js +++ b/lib/Structures/ChannelPermissions.js @@ -45,8 +45,8 @@ var ChannelPermissions = (function () { } if (!explicit) { // implicit permissions allowed - if (!!(this.permissions & _Constants.Permissions.manageRoles)) { - // manageRoles allowed, they have all permissions + if (!!(this.permissions & _Constants.Permissions.administrator)) { + // administrator allowed, they have all permissions return true; } } diff --git a/lib/Structures/Role.js b/lib/Structures/Role.js index bf222c842..eabdde7bc 100644 --- a/lib/Structures/Role.js +++ b/lib/Structures/Role.js @@ -118,7 +118,7 @@ var Role = (function () { if (!explicit) { // implicit permissions allowed if (!!(this.permissions & _Constants.Permissions.administrator)) { - // manageRoles allowed, they have all permissions + // administrator allowed, they have all permissions return true; } } diff --git a/src/Structures/Role.js b/src/Structures/Role.js index 708c1fafb..f6a3d7284 100644 --- a/src/Structures/Role.js +++ b/src/Structures/Role.js @@ -54,7 +54,7 @@ export default class Role { for (let k of keys) { obj[k] = this[k]; } - + return obj; } @@ -104,7 +104,7 @@ export default class Role { } if(!explicit){ // implicit permissions allowed if( !!(this.permissions & Permissions.administrator) ){ - // manageRoles allowed, they have all permissions + // administrator allowed, they have all permissions return true; } }