Cleanup Part 2: Electric Boogaloo (Reloaded) (#594)

* Cleanup Part 2: Electric Boogaloo (Reloaded)

* Moar cleanup

* Tweak NOT_A_PERMISSION error

src/client/voice/opus/NodeOpusEngine.js

@@ -6,7 +6,6 @@ class NodeOpusEngine extends OpusEngine {
   constructor(player) {
     super(player);
     try {
-      // eslint-disable-next-line import/no-unresolved
       opus = require('node-opus');
     } catch (err) {
       throw err;

src/client/voice/opus/OpusEngineList.js

@@ -3,10 +3,6 @@ const list = [
   require('./OpusScriptEngine'),
 ];
 
-exports.add = encoder => {
-  list.push(encoder);
-};
-
 function fetch(Encoder) {
   try {
     return new Encoder();
@@ -15,12 +11,14 @@ function fetch(Encoder) {
   }
 }
 
+exports.add = encoder => {
+  list.push(encoder);
+};
+
 exports.fetch = () => {
   for (const encoder of list) {
-    const success = fetch(encoder);
-    if (success) {
-      return success;
-    }
+    const fetched = fetch(encoder);
+    if (fetched) return fetched;
   }
   throw new Error('could not find an opus engine');
 };

src/client/voice/opus/OpusScriptEngine.js

@@ -1,17 +1,16 @@
 const OpusEngine = require('./BaseOpusEngine');
 
-let Opusscript;
+let OpusScript;
 
 class NodeOpusEngine extends OpusEngine {
   constructor(player) {
     super(player);
     try {
-      // eslint-disable-next-line import/no-unresolved
-      Opusscript = require('opusscript');
+      OpusScript = require('opusscript');
     } catch (err) {
       throw err;
     }
-    this.encoder = new Opusscript(48000, 2);
+    this.encoder = new OpusScript(48000, 2);
   }
 
   encode(buffer) {