Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-13 18:13:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix Guild#createRole with position (#1720)

Browse Source 
* Fix Guild#createRole with position + validation

* remove position validation, small update

* fixed async issue if position provided
This commit is contained in:
Isabella
2017-08-20 16:36:22 -05:00
committed by Crawl
parent 2c763073d7
commit 0c0ec72cb8
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/structures/Guild.js
View File

@@ -1043,6 +1043,7 @@ class Guild {
/** /**
* Creates a new role in the guild with given information * Creates a new role in the guild with given information
* <warn>The position will silently reset to 1 if an invalid one is provided, or none.</warn>
* @param {Object} [options] Options * @param {Object} [options] Options
* @param {RoleData} [options.data] The data to update the role with * @param {RoleData} [options.data] The data to update the role with
* @param {string} [options.reason] Reason for creating this role * @param {string} [options.reason] Reason for creating this role
@@ -1068,12 +1069,14 @@ class Guild {
if (data.color) data.color = Util.resolveColor(data.color); if (data.color) data.color = Util.resolveColor(data.color);
if (data.permissions) data.permissions = Permissions.resolve(data.permissions); if (data.permissions) data.permissions = Permissions.resolve(data.permissions);
return this.client.api.guilds(this.id).roles.post({ data, reason }).then(role => return this.client.api.guilds(this.id).roles.post({ data, reason }).then(r => {
this.client.actions.GuildRoleCreate.handle({ const { role } = this.client.actions.GuildRoleCreate.handle({
guild_id: this.id, guild_id: this.id,
role, role: r,
}).role });
); if (data.position) return role.setPosition(data.position, reason);
return role;
});
} }
/** /**