Add new ESLint rules

src/client/actions/GuildDelete.js

@@ -17,18 +17,18 @@ class GuildDeleteAction extends Action {
       }
 
       if (guild.available && data.unavailable) {
-        // guild is unavailable
+        // Guild is unavailable
         guild.available = false;
         client.emit(Constants.Events.GUILD_UNAVAILABLE, guild);
 
-        // stops the GuildDelete packet thinking a guild was actually deleted,
+        // Stops the GuildDelete packet thinking a guild was actually deleted,
         // handles emitting of event itself
         return {
           guild: null,
         };
       }
 
-      // delete guild
+      // Delete guild
       client.guilds.delete(guild.id);
       this.deleted.set(guild.id, guild);
       this.scheduleForDeletion(guild.id);

src/client/rest/RESTMethods.js

@@ -354,7 +354,7 @@ class RESTMethods {
     });
   }
 
-  // untested but probably will work
+  // Untested but probably will work
   deleteGuild(guild) {
     return this.rest.makeRequest('del', Constants.Endpoints.guild(guild.id), true).then(() =>
       this.client.actions.GuildDelete.handle({ id: guild.id }).guild
@@ -486,7 +486,7 @@ class RESTMethods {
     if (data.roles) data.roles = data.roles.map(role => role instanceof Role ? role.id : role);
 
     let endpoint = Constants.Endpoints.guildMember(member.guild.id, member.id);
-    // fix your endpoints, discord ;-;
+    // Fix your endpoints, discord ;-;
     if (member.id === this.client.user.id) {
       const keys = Object.keys(data);
       if (keys.length === 1 && keys[0] === 'nick') {

src/client/rest/RequestHandlers/RequestHandler.js

@@ -43,9 +43,7 @@ class RequestHandler {
   /**
    * Attempts to get this RequestHandler to process its current queue
    */
-  handle() {
-    return;
-  }
+  handle() {} // eslint-disable-line no-empty-function
 }
 
 module.exports = RequestHandler;

src/client/voice/VoiceBroadcast.js

@@ -267,6 +267,7 @@ class VoiceBroadcast extends VolumeInterface {
 
   _startPlaying() {
     if (this.tickInterval) clearInterval(this.tickInterval);
+    // Old code?
     // this.tickInterval = this.client.setInterval(this.tick.bind(this), 20);
     this._startTime = Date.now();
     this._count = 0;

src/client/voice/dispatcher/StreamDispatcher.js

@@ -203,6 +203,7 @@ class StreamDispatcher extends VolumeInterface {
 
       if (this.paused) {
         this.setSpeaking(false);
+        // Old code?
         // data.timestamp = data.timestamp + 4294967295 ? data.timestamp + 960 : 0;
         data.pausedTime += data.length * 10;
         this.player.voiceConnection.voiceManager.client.setTimeout(() => this.process(), data.length * 10);

src/client/voice/opus/BaseOpusEngine.js

@@ -11,9 +11,7 @@ class BaseOpus {
     return buffer;
   }
 
-  destroy() {
-    return;
-  }
+  destroy() {} // eslint-disable-line no-empty-function
 }
 
 module.exports = BaseOpus;

src/client/voice/receiver/VoiceReadable.js

@@ -7,9 +7,7 @@ class VoiceReadable extends Readable {
     this.open = true;
   }
 
-  _read() {
-    return;
-  }
+  _read() {} // eslint-disable-line no-empty-function
 
   _push(d) {
     if (this.open) this.push(d);

src/client/voice/receiver/VoiceReceiver.js

@@ -20,7 +20,7 @@ class VoiceReceiver extends EventEmitter {
   constructor(connection) {
     super();
     /*
-      need a queue because we don't get the ssrc of the user speaking until after the first few packets,
+      Need a queue because we don't get the ssrc of the user speaking until after the first few packets,
       so we queue up unknown SSRCs until they become known, then empty the queue.
     */
     this.queues = new Map();
@@ -68,7 +68,6 @@ class VoiceReceiver extends EventEmitter {
     if (!this.destroyed) return;
     this.voiceConnection.sockets.udp.socket.on('message', this._listener);
     this.destroyed = false;
-    return;
   }
 
   /**

src/client/websocket/packets/handlers/GuildCreate.js

@@ -8,12 +8,12 @@ class GuildCreateHandler extends AbstractHandler {
     const guild = client.guilds.get(data.id);
     if (guild) {
       if (!guild.available && !data.unavailable) {
-        // a newly available guild
+        // A newly available guild
         guild.setup(data);
         this.packetManager.ws.checkIfReady();
       }
     } else {
-      // a new guild
+      // A new guild
       client.dataManager.newGuild(data);
     }
   }

src/client/websocket/packets/handlers/GuildEmojisUpdate.js

@@ -16,22 +16,22 @@ class GuildEmojisUpdate extends AbstractHandler {
     const deletions = mappify(guild.emojis.entries());
 
     for (const emoji of data.emojis) {
-      // determine type of emoji event
+      // Determine type of emoji event
       const cachedEmoji = guild.emojis.get(emoji.id);
       if (cachedEmoji) {
         deletions.delete(emoji.id);
         if (!cachedEmoji.equals(emoji, true)) {
-          // emoji updated
+          // Emoji updated
           client.actions.GuildEmojiUpdate.handle(cachedEmoji, emoji);
         }
       } else {
-        // emoji added
+        // Emoji added
         client.actions.GuildEmojiCreate.handle(guild, emoji);
       }
     }
 
     for (const emoji of deletions.values()) {
-      // emoji deleted
+      // Emoji deleted
       client.actions.GuildEmojiDelete.handle(emoji);
     }
   }

src/client/websocket/packets/handlers/GuildMembersChunk.js

@@ -1,6 +1,6 @@
 const AbstractHandler = require('./AbstractHandler');
 const Constants = require('../../../../util/Constants');
-// uncomment in v12
+// Uncomment in v12
 // const Collection = require('../../../../util/Collection');
 
 class GuildMembersChunkHandler extends AbstractHandler {
@@ -10,7 +10,7 @@ class GuildMembersChunkHandler extends AbstractHandler {
     const guild = client.guilds.get(data.guild_id);
     if (!guild) return;
 
-    // uncomment in v12
+    // Uncomment in v12
     // const members = new Collection();
     //
     // for (const member of data.members) members.set(member.id, guild._addMember(member, false));

src/client/websocket/packets/handlers/PresenceUpdate.js

@@ -9,7 +9,7 @@ class PresenceUpdateHandler extends AbstractHandler {
     let user = client.users.get(data.user.id);
     const guild = client.guilds.get(data.guild_id);
 
-    // step 1
+    // Step 1
     if (!user) {
       if (data.user.username) {
         user = client.dataManager.newUser(data.user);

src/client/websocket/packets/handlers/VoiceStateUpdate.js

@@ -17,7 +17,7 @@ class VoiceStateUpdateHandler extends AbstractHandler {
           member.voiceChannel.members.delete(oldVoiceChannelMember.id);
         }
 
-        // if the member left the voice channel, unset their speaking property
+        // If the member left the voice channel, unset their speaking property
         if (!data.channel_id) member.speaking = null;
 
         if (member.user.id === client.user.id && data.channel_id) {