Add new ESLint rules

This commit is contained in:
Schuyler Cebulskie
2017-03-17 01:23:39 -04:00
parent 2237749d29
commit 136cab240d
26 changed files with 117 additions and 110 deletions

View File

@@ -8,12 +8,12 @@ class GuildCreateHandler extends AbstractHandler {
const guild = client.guilds.get(data.id);
if (guild) {
if (!guild.available && !data.unavailable) {
// a newly available guild
// A newly available guild
guild.setup(data);
this.packetManager.ws.checkIfReady();
}
} else {
// a new guild
// A new guild
client.dataManager.newGuild(data);
}
}

View File

@@ -16,22 +16,22 @@ class GuildEmojisUpdate extends AbstractHandler {
const deletions = mappify(guild.emojis.entries());
for (const emoji of data.emojis) {
// determine type of emoji event
// Determine type of emoji event
const cachedEmoji = guild.emojis.get(emoji.id);
if (cachedEmoji) {
deletions.delete(emoji.id);
if (!cachedEmoji.equals(emoji, true)) {
// emoji updated
// Emoji updated
client.actions.GuildEmojiUpdate.handle(cachedEmoji, emoji);
}
} else {
// emoji added
// Emoji added
client.actions.GuildEmojiCreate.handle(guild, emoji);
}
}
for (const emoji of deletions.values()) {
// emoji deleted
// Emoji deleted
client.actions.GuildEmojiDelete.handle(emoji);
}
}

View File

@@ -1,6 +1,6 @@
const AbstractHandler = require('./AbstractHandler');
const Constants = require('../../../../util/Constants');
// uncomment in v12
// Uncomment in v12
// const Collection = require('../../../../util/Collection');
class GuildMembersChunkHandler extends AbstractHandler {
@@ -10,7 +10,7 @@ class GuildMembersChunkHandler extends AbstractHandler {
const guild = client.guilds.get(data.guild_id);
if (!guild) return;
// uncomment in v12
// Uncomment in v12
// const members = new Collection();
//
// for (const member of data.members) members.set(member.id, guild._addMember(member, false));

View File

@@ -9,7 +9,7 @@ class PresenceUpdateHandler extends AbstractHandler {
let user = client.users.get(data.user.id);
const guild = client.guilds.get(data.guild_id);
// step 1
// Step 1
if (!user) {
if (data.user.username) {
user = client.dataManager.newUser(data.user);

View File

@@ -17,7 +17,7 @@ class VoiceStateUpdateHandler extends AbstractHandler {
member.voiceChannel.members.delete(oldVoiceChannelMember.id);
}
// if the member left the voice channel, unset their speaking property
// If the member left the voice channel, unset their speaking property
if (!data.channel_id) member.speaking = null;
if (member.user.id === client.user.id && data.channel_id) {