From 152d2e88bd94371e20df4702d08c139f6861ea02 Mon Sep 17 00:00:00 2001 From: izexi <43889168+izexi@users.noreply.github.com> Date: Mon, 8 Apr 2019 13:06:23 +0100 Subject: [PATCH] refactor(WebSocket): utilize URLSearchParams (#3185) * replace querystring with URLSearchParams * looks a bit nicer using urlSearchParams.set(...) --- src/WebSocket.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/WebSocket.js b/src/WebSocket.js index 2a303cc46..c8f73972a 100644 --- a/src/WebSocket.js +++ b/src/WebSocket.js @@ -1,7 +1,6 @@ 'use strict'; const { browser } = require('./util/Constants'); -const querystring = require('querystring'); try { var erlpack = require('erlpack'); if (!erlpack.pack) erlpack = null; @@ -30,8 +29,9 @@ exports.unpack = data => { exports.create = (gateway, query = {}, ...args) => { const [g, q] = gateway.split('?'); query.encoding = exports.encoding; - if (q) query = Object.assign(querystring.parse(q), query); - const ws = new exports.WebSocket(`${g}?${querystring.stringify(query)}`, ...args); + query = new URLSearchParams(query); + if (q) new URLSearchParams(q).forEach((v, k) => query.set(k, v)); + const ws = new exports.WebSocket(`${g}?${query}`, ...args); if (browser) ws.binaryType = 'arraybuffer'; return ws; };