From 176fc47699e43c0eeb5fc9d097ffea692e2cbc75 Mon Sep 17 00:00:00 2001 From: izexi <43889168+izexi@users.noreply.github.com> Date: Fri, 3 May 2019 16:38:57 +0100 Subject: [PATCH] feat(Actions): use partials for messageDeleteBulk (#3240) * make use of partials * don't cache the messages * pass each message within the for..of iteration --- src/client/actions/Action.js | 4 ++-- src/client/actions/MessageDeleteBulk.js | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/client/actions/Action.js b/src/client/actions/Action.js index 5746d2764..0b03c071b 100644 --- a/src/client/actions/Action.js +++ b/src/client/actions/Action.js @@ -33,14 +33,14 @@ class GenericAction { this.client.channels.get(id)); } - getMessage(data, channel) { + getMessage(data, channel, cache = true) { const id = data.message_id || data.id; return data.message || (this.client.options.partials.includes(PartialTypes.MESSAGE) ? channel.messages.add({ id, channel_id: channel.id, guild_id: data.guild_id || (channel.guild ? channel.guild.id : null), - }) : + }, cache) : channel.messages.get(id)); } diff --git a/src/client/actions/MessageDeleteBulk.js b/src/client/actions/MessageDeleteBulk.js index 53f4ba051..f80bc7c4d 100644 --- a/src/client/actions/MessageDeleteBulk.js +++ b/src/client/actions/MessageDeleteBulk.js @@ -13,7 +13,10 @@ class MessageDeleteBulkAction extends Action { const ids = data.ids; const messages = new Collection(); for (const id of ids) { - const message = channel.messages.get(id); + const message = this.getMessage({ + id, + guild_id: data.guild_id, + }, channel, false); if (message) { message.deleted = true; messages.set(message.id, message);