From 1fb7b30963cfe7ea4c05b1f3b42171c879c46a1d Mon Sep 17 00:00:00 2001 From: Almeida Date: Wed, 20 Jul 2022 19:12:58 +0100 Subject: [PATCH] fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions (#8311) * fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions * fix(ApplicationCommand): equals() --- .../discord.js/src/managers/ApplicationCommandManager.js | 7 ++++--- packages/discord.js/src/structures/ApplicationCommand.js | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/discord.js/src/managers/ApplicationCommandManager.js b/packages/discord.js/src/managers/ApplicationCommandManager.js index 23bddabef..a2cfae4ce 100644 --- a/packages/discord.js/src/managers/ApplicationCommandManager.js +++ b/packages/discord.js/src/managers/ApplicationCommandManager.js @@ -242,9 +242,10 @@ class ApplicationCommandManager extends CachedManager { } if ('defaultMemberPermissions' in command) { - default_member_permissions = command.defaultMemberPermissions - ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString() - : command.defaultMemberPermissions; + default_member_permissions = + command.defaultMemberPermissions !== null + ? new PermissionsBitField(command.defaultMemberPermissions).bitfield.toString() + : command.defaultMemberPermissions; } return { diff --git a/packages/discord.js/src/structures/ApplicationCommand.js b/packages/discord.js/src/structures/ApplicationCommand.js index 8bca0b08e..afdddaca9 100644 --- a/packages/discord.js/src/structures/ApplicationCommand.js +++ b/packages/discord.js/src/structures/ApplicationCommand.js @@ -365,9 +365,10 @@ class ApplicationCommand extends Base { } if ('defaultMemberPermissions' in command) { - defaultMemberPermissions = command.defaultMemberPermissions - ? new PermissionsBitField(command.defaultMemberPermissions).bitfield - : null; + defaultMemberPermissions = + command.defaultMemberPermissions !== null + ? new PermissionsBitField(command.defaultMemberPermissions).bitfield + : null; } // Check top level parameters