From 2a684361d430d4c951be931e3644060117fbccea Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Thu, 13 Apr 2023 21:09:40 +0100 Subject: [PATCH] fix(guide): Treeshake react-icons (#9381) --- apps/guide/package.json | 1 - apps/guide/src/components/DocsLink.tsx | 3 ++- apps/guide/src/components/ExternalLink.tsx | 10 ---------- yarn.lock | 10 ---------- 4 files changed, 2 insertions(+), 22 deletions(-) delete mode 100644 apps/guide/src/components/ExternalLink.tsx diff --git a/apps/guide/package.json b/apps/guide/package.json index 46ad617da..a2966cd5b 100644 --- a/apps/guide/package.json +++ b/apps/guide/package.json @@ -58,7 +58,6 @@ "react": "^18.2.0", "react-custom-scrollbars-2": "^4.5.0", "react-dom": "^18.2.0", - "react-icons": "^4.8.0", "react-use": "^17.4.0", "rehype-autolink-headings": "^6.1.1", "rehype-ignore": "^1.0.5", diff --git a/apps/guide/src/components/DocsLink.tsx b/apps/guide/src/components/DocsLink.tsx index 168e26b1d..274db38e9 100644 --- a/apps/guide/src/components/DocsLink.tsx +++ b/apps/guide/src/components/DocsLink.tsx @@ -1,4 +1,4 @@ -import { FiExternalLink } from 'react-icons/fi'; +import { FiExternalLink } from '@react-icons/all-files/fi/FiExternalLink'; import { BASE_URL, BASE_URL_LEGACY, PACKAGES, VERSION } from '~/util/constants'; interface DocsLinkOptions { @@ -61,6 +61,7 @@ export function DocsLink({ if (trimmedSymbol) url += `?scrollTo=${trimmedSymbol}`; text = `${parent}${trimmedSymbol ? (trimmedSymbol.startsWith('s-') ? '.' : '#') : ''}${ + // eslint-disable-next-line prefer-named-capture-group trimmedSymbol ? `${trimmedSymbol.replace(/(e|s)-/, '')}` : '' }${bracketText}`; } else { diff --git a/apps/guide/src/components/ExternalLink.tsx b/apps/guide/src/components/ExternalLink.tsx deleted file mode 100644 index a32b9a7a5..000000000 --- a/apps/guide/src/components/ExternalLink.tsx +++ /dev/null @@ -1,10 +0,0 @@ -import { FiExternalLink } from 'react-icons/fi'; - -export function ExternalLink({ href, title }: { href: string; title: string }) { - return ( - -

{title}

- -
- ); -} diff --git a/yarn.lock b/yarn.lock index 955428ad4..0c64e96da 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2225,7 +2225,6 @@ __metadata: react: ^18.2.0 react-custom-scrollbars-2: ^4.5.0 react-dom: ^18.2.0 - react-icons: ^4.8.0 react-use: ^17.4.0 rehype-autolink-headings: ^6.1.1 rehype-ignore: ^1.0.5 @@ -21170,15 +21169,6 @@ __metadata: languageName: node linkType: hard -"react-icons@npm:^4.8.0": - version: 4.8.0 - resolution: "react-icons@npm:4.8.0" - peerDependencies: - react: "*" - checksum: 4dbba7ad989c295b410e19b2a702722dae44368cb04b6515f9471353552f31ac80bd350f121d5bff79f81504b84039ede44d09e9f035f48bb1032e6eace126c4 - languageName: node - linkType: hard - "react-inspector@npm:^6.0.0": version: 6.0.1 resolution: "react-inspector@npm:6.0.1"