From 307389a335d0fef25c6e8a3c7e401b1328629bc4 Mon Sep 17 00:00:00 2001 From: Khafra <42794878+KhafraDev@users.noreply.github.com> Date: Tue, 18 Jan 2022 05:21:05 -0500 Subject: [PATCH] BaseClient: pass `captureRejections` option (#7288) --- packages/discord.js/src/client/BaseClient.js | 2 +- packages/discord.js/src/sharding/ShardClientUtil.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/discord.js/src/client/BaseClient.js b/packages/discord.js/src/client/BaseClient.js index 59b4dd215..65149ff46 100644 --- a/packages/discord.js/src/client/BaseClient.js +++ b/packages/discord.js/src/client/BaseClient.js @@ -13,7 +13,7 @@ const Util = require('../util/Util'); */ class BaseClient extends EventEmitter { constructor(options = {}) { - super(); + super({ captureRejections: true }); if (typeof options !== 'object' || options === null) { throw new TypeError('INVALID_TYPE', 'options', 'object', true); diff --git a/packages/discord.js/src/sharding/ShardClientUtil.js b/packages/discord.js/src/sharding/ShardClientUtil.js index 982d4090d..a89709513 100644 --- a/packages/discord.js/src/sharding/ShardClientUtil.js +++ b/packages/discord.js/src/sharding/ShardClientUtil.js @@ -210,6 +210,9 @@ class ShardClientUtil { error.stack = err.stack; /** * Emitted when the client encounters an error. + * Errors thrown within this event do not have a catch handler, it is + * recommended to not use async functions as `error` event handlers. See the + * [Node.js docs](https://nodejs.org/api/events.html#capture-rejections-of-promises) for details. * @event Client#error * @param {Error} error The error encountered */