Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-17 03:53:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: slash command name regex (#8265)

Browse Source
This commit is contained in:
Tiemen
2022-07-17 18:52:18 +02:00
committed by GitHub
parent 3648f6d567
commit 32f9056b15
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
packages/builders/__tests__/interactions/SlashCommands/SlashCommands.test.ts
View File

@@ -42,6 +42,8 @@ describe('Slash Commands', () => {
describe('Assertions tests', () => { describe('Assertions tests', () => {
test('GIVEN valid name THEN does not throw error', () => { test('GIVEN valid name THEN does not throw error', () => {
expect(() => SlashCommandAssertions.validateName('ping')).not.toThrowError(); expect(() => SlashCommandAssertions.validateName('ping')).not.toThrowError();
expect(() => SlashCommandAssertions.validateName('hello-world_command')).not.toThrowError();
expect(() => SlashCommandAssertions.validateName('aˇ㐆1٢〣²अก')).not.toThrowError();
}); });
test('GIVEN invalid name THEN throw error', () => { test('GIVEN invalid name THEN throw error', () => {
@@ -51,7 +53,10 @@ describe('Slash Commands', () => {
expect(() => SlashCommandAssertions.validateName('')).toThrowError(); expect(() => SlashCommandAssertions.validateName('')).toThrowError();
// Invalid characters used // Invalid characters used
expect(() => SlashCommandAssertions.validateName('ABC')).toThrowError();
expect(() => SlashCommandAssertions.validateName('ABC123$%^&')).toThrowError(); expect(() => SlashCommandAssertions.validateName('ABC123$%^&')).toThrowError();
expect(() => SlashCommandAssertions.validateName('help ping')).toThrowError();
expect(() => SlashCommandAssertions.validateName('🦦')).toThrowError();
// Too long of a name // Too long of a name
expect(() => expect(() =>

2
packages/builders/src/interactions/slashCommands/Assertions.ts
View File

@@ -8,7 +8,7 @@ import { isValidationEnabled } from '../../util/validation';
const namePredicate = s.string const namePredicate = s.string
.lengthGreaterThanOrEqual(1) .lengthGreaterThanOrEqual(1)
.lengthLessThanOrEqual(32) .lengthLessThanOrEqual(32)
.regex(/^[\P{Lu}\p{N}\p{sc=Devanagari}\p{sc=Thai}_-]+$/u) .regex(/^[\p{Ll}\p{Lm}\p{Lo}\p{N}\p{sc=Devanagari}\p{sc=Thai}_-]+$/u)
.setValidationEnabled(isValidationEnabled); .setValidationEnabled(isValidationEnabled);
export function validateName(name: unknown): asserts name is string { export function validateName(name: unknown): asserts name is string {