Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-19 21:13:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(components): setX should take rest parameters (#7461)

Browse Source
This commit is contained in:
muchnameless
2022-02-15 18:31:08 +01:00
committed by GitHub
parent 003439671d
commit 36173590a7
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/builders/__tests__/components/actionRow.test.ts
View File

@@ -5,7 +5,7 @@ describe('Action Row Components', () => {
describe('Assertion Tests', () => { describe('Assertion Tests', () => {
test('GIVEN valid components THEN do not throw', () => { test('GIVEN valid components THEN do not throw', () => {
expect(() => new ActionRow().addComponents(new ButtonComponent())).not.toThrowError(); expect(() => new ActionRow().addComponents(new ButtonComponent())).not.toThrowError();
expect(() => new ActionRow().setComponents([new ButtonComponent()])).not.toThrowError(); expect(() => new ActionRow().setComponents(new ButtonComponent())).not.toThrowError();
}); });
test('GIVEN valid JSON input THEN valid JSON output is given', () => { test('GIVEN valid JSON input THEN valid JSON output is given', () => {
@@ -84,10 +84,10 @@ describe('Action Row Components', () => {
.setCustomId('1234') .setCustomId('1234')
.setMaxValues(10) .setMaxValues(10)
.setMinValues(12) .setMinValues(12)
.setOptions([ .setOptions(
new SelectMenuOption().setLabel('one').setValue('one'), new SelectMenuOption().setLabel('one').setValue('one'),
new SelectMenuOption().setLabel('two').setValue('two'), new SelectMenuOption().setLabel('two').setValue('two'),
]); );
expect(new ActionRow().addComponents(button).toJSON()).toEqual(rowWithButtonData); expect(new ActionRow().addComponents(button).toJSON()).toEqual(rowWithButtonData);
expect(new ActionRow().addComponents(selectMenu).toJSON()).toEqual(rowWithSelectMenuData); expect(new ActionRow().addComponents(selectMenu).toJSON()).toEqual(rowWithSelectMenuData);

2
packages/builders/src/components/ActionRow.ts
View File

@@ -35,7 +35,7 @@ export class ActionRow<T extends ActionRowComponent = ActionRowComponent> extend
* Sets the components in this action row * Sets the components in this action row
* @param components The components to set this row to * @param components The components to set this row to
*/ */
public setComponents(components: T[]) { public setComponents(...components: T[]) {
this.components.splice(0, this.components.length, ...components); this.components.splice(0, this.components.length, ...components);
return this; return this;
} }

2
packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts
View File

@@ -110,7 +110,7 @@ export class UnsafeSelectMenuComponent extends Component<
* Sets the options on this select menu * Sets the options on this select menu
* @param options The options to set on this select menu * @param options The options to set on this select menu
*/ */
public setOptions(options: UnsafeSelectMenuOption[]) { public setOptions(...options: UnsafeSelectMenuOption[]) {
this.options.splice(0, this.options.length, ...options); this.options.splice(0, this.options.length, ...options);
return this; return this;
} }