diff --git a/src/client/voice/VoiceBroadcast.js b/src/client/voice/VoiceBroadcast.js index c2e373b36..96965c954 100644 --- a/src/client/voice/VoiceBroadcast.js +++ b/src/client/voice/VoiceBroadcast.js @@ -55,11 +55,10 @@ class VoiceBroadcast extends EventEmitter { return d; } - applyVolume(buffer, volume) { - volume = volume || this._volume; + applyVolume(buffer, volume = this._volume) { if (volume === 1) return buffer; - const out = new Buffer(buffer.length); + const out = Buffer.alloc(buffer.length); for (let i = 0; i < buffer.length; i += 2) { if (i >= buffer.length - 1) break; const uint = Math.min(32767, Math.max(-32767, Math.floor(volume * buffer.readInt16LE(i)))); @@ -319,7 +318,7 @@ class VoiceBroadcast extends EventEmitter { this._missed = 0; if (buffer.length !== bufferLength) { - const newBuffer = new Buffer(bufferLength).fill(0); + const newBuffer = Buffer.alloc(bufferLength).fill(0); buffer.copy(newBuffer); buffer = newBuffer; } diff --git a/src/client/voice/VoiceUDPClient.js b/src/client/voice/VoiceUDPClient.js index b7b0c0cfe..7fc2ca577 100644 --- a/src/client/voice/VoiceUDPClient.js +++ b/src/client/voice/VoiceUDPClient.js @@ -124,7 +124,7 @@ class VoiceConnectionUDPClient extends EventEmitter { }); }); - const blankMessage = new Buffer(70); + const blankMessage = Buffer.alloc(70); blankMessage.writeUIntBE(this.voiceConnection.authentication.ssrc, 0, 4); this.send(blankMessage); } @@ -132,7 +132,7 @@ class VoiceConnectionUDPClient extends EventEmitter { function parseLocalPacket(message) { try { - const packet = new Buffer(message); + const packet = Buffer.from(message); let address = ''; for (let i = 4; i < packet.indexOf(0, i); i++) address += String.fromCharCode(packet[i]); const port = parseInt(packet.readUIntLE(packet.length - 2, 2).toString(10), 10); diff --git a/src/client/voice/dispatcher/StreamDispatcher.js b/src/client/voice/dispatcher/StreamDispatcher.js index 3edb759f5..0fa0f2368 100644 --- a/src/client/voice/dispatcher/StreamDispatcher.js +++ b/src/client/voice/dispatcher/StreamDispatcher.js @@ -2,7 +2,7 @@ const EventEmitter = require('events').EventEmitter; const NaCl = require('tweetnacl'); const VoiceBroadcast = require('../VoiceBroadcast'); -const nonce = new Buffer(24); +const nonce = Buffer.alloc(24); nonce.fill(0); /** @@ -180,7 +180,7 @@ class StreamDispatcher extends EventEmitter { } createPacket(sequence, timestamp, buffer) { - const packetBuffer = new Buffer(buffer.length + 28); + const packetBuffer = Buffer.alloc(buffer.length + 28); packetBuffer.fill(0); packetBuffer[0] = 0x80; packetBuffer[1] = 0x78; @@ -199,7 +199,7 @@ class StreamDispatcher extends EventEmitter { applyVolume(buffer) { if (this.volume === 1) return buffer; - const out = new Buffer(buffer.length); + const out = Buffer.alloc(buffer.length); for (let i = 0; i < buffer.length; i += 2) { if (i >= buffer.length - 1) break; const uint = Math.min(32767, Math.max(-32767, Math.floor(this.volume * buffer.readInt16LE(i)))); @@ -269,7 +269,7 @@ class StreamDispatcher extends EventEmitter { data.missed = 0; if (buffer.length !== bufferLength) { - const newBuffer = new Buffer(bufferLength).fill(0); + const newBuffer = Buffer.alloc(bufferLength).fill(0); buffer.copy(newBuffer); buffer = newBuffer; } diff --git a/src/client/voice/receiver/VoiceReceiver.js b/src/client/voice/receiver/VoiceReceiver.js index bc9156f2f..697e8df12 100644 --- a/src/client/voice/receiver/VoiceReceiver.js +++ b/src/client/voice/receiver/VoiceReceiver.js @@ -2,7 +2,7 @@ const EventEmitter = require('events').EventEmitter; const NaCl = require('tweetnacl'); const Readable = require('./VoiceReadable'); -const nonce = new Buffer(24); +const nonce = Buffer.alloc(24); nonce.fill(0); /** @@ -127,7 +127,7 @@ class VoiceReceiver extends EventEmitter { this.emit('warn', 'Failed to decrypt voice packet'); return; } - data = new Buffer(data); + data = Buffer.from(data); if (this.opusStreams.get(user.id)) this.opusStreams.get(user.id)._push(data); /** * Emitted whenever voice data is received from the voice connection. This is _always_ emitted (unlike PCM).