Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-18 12:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(GuildMemberRoleStore): only update roles after successful request

Browse Source 
Fixes #2381
This commit is contained in:
Pascal
2018-03-05 11:32:03 +01:00
parent 8b679913a4
commit 3f6a0e4de1
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/stores/GuildMemberRoleStore.js
View File

@@ -29,11 +29,9 @@ class GuildMemberRoleStore extends DataStore {
if (roleOrRoles.includes(null)) { if (roleOrRoles.includes(null)) {
return Promise.reject(new TypeError('INVALID_TYPE', 'roles', return Promise.reject(new TypeError('INVALID_TYPE', 'roles',
'Array or Collection of Roles or Snowflakes', true)); 'Array or Collection of Roles or Snowflakes', true));
} else {
for (const role of roleOrRoles) super.set(role.id, role);
} }
const newRoles = [...new Set(roleOrRoles.concat(this.array()))];
return this.set(this, reason); return this.set(newRoles, reason);
} }
/** /**
@@ -71,11 +69,9 @@ class GuildMemberRoleStore extends DataStore {
if (roleOrRoles.includes(null)) { if (roleOrRoles.includes(null)) {
return Promise.reject(new TypeError('INVALID_TYPE', 'roles', return Promise.reject(new TypeError('INVALID_TYPE', 'roles',
'Array or Collection of Roles or Snowflakes', true)); 'Array or Collection of Roles or Snowflakes', true));
} else {
for (const role of roleOrRoles) super.remove(role);
} }
const newRoles = [...new Set(roleOrRoles.concat(this.array()))];
return this.set(this, reason); return this.set(newRoles, reason);
} }
/** /**