chore: add strict mode (#2974)

.eslintrc.json

@@ -11,6 +11,7 @@
     { "files": ["*.browser.js"], "env": { "browser": true } }
   ],
   "rules": {
+    "strict": ["error", "global"],
     "no-await-in-loop": "warn",
     "no-compare-neg-zero": "error",
     "no-extra-parens": ["warn", "all", {

src/WebSocket.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { browser } = require('./util/Constants');
 const querystring = require('querystring');
 try {

src/client/BaseClient.js

@@ -1,3 +1,5 @@
+'use strict';
+
 require('setimmediate');
 const EventEmitter = require('events');
 const RESTManager = require('../rest/RESTManager');

src/client/Client.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const BaseClient = require('./BaseClient');
 const Permissions = require('../util/Permissions');
 const ClientVoiceManager = require('./voice/ClientVoiceManager');

src/client/WebhookClient.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Webhook = require('../structures/Webhook');
 const BaseClient = require('./BaseClient');
 

src/client/actions/Action.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /*
 
 ABOUT ACTIONS

src/client/actions/ActionsManager.js

@@ -1,3 +1,5 @@
+'use strict';
+
 class ActionsManager {
   constructor(client) {
     this.client = client;

src/client/actions/ChannelCreate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/ChannelDelete.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/ChannelUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 
 class ChannelUpdateAction extends Action {

src/client/actions/GuildBanRemove.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildChannelsPositionUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 
 class GuildChannelsPositionUpdate extends Action {

src/client/actions/GuildDelete.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildEmojiCreate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildEmojiDelete.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildEmojiUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildEmojisUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 
 class GuildEmojisUpdateAction extends Action {

src/client/actions/GuildIntegrationsUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildMemberRemove.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events, Status } = require('../../util/Constants');
 

src/client/actions/GuildRoleCreate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildRoleDelete.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildRoleUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/GuildRolesPositionUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 
 class GuildRolesPositionUpdate extends Action {

src/client/actions/GuildUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/MessageCreate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/MessageDelete.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/MessageDeleteBulk.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const Collection = require('../../util/Collection');
 const { Events } = require('../../util/Constants');

src/client/actions/MessageReactionAdd.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 
 /*

src/client/actions/MessageReactionRemove.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/MessageReactionRemoveAll.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/MessageUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 
 class MessageUpdateAction extends Action {

src/client/actions/PresenceUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/UserUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/actions/VoiceStateUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 const VoiceState = require('../../structures/VoiceState');

src/client/actions/WebhooksUpdate.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Action = require('./Action');
 const { Events } = require('../../util/Constants');
 

src/client/voice/ClientVoiceManager.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Collection = require('../../util/Collection');
 const { VoiceStatus } = require('../../util/Constants');
 const VoiceConnection = require('./VoiceConnection');

src/client/voice/VoiceBroadcast.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const EventEmitter = require('events');
 const BroadcastAudioPlayer = require('./player/BroadcastAudioPlayer');
 const DispatcherSet = require('./util/DispatcherSet');

src/client/voice/VoiceConnection.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const VoiceWebSocket = require('./networking/VoiceWebSocket');
 const VoiceUDP = require('./networking/VoiceUDPClient');
 const Util = require('../../util/Util');

src/client/voice/dispatcher/BroadcastDispatcher.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const StreamDispatcher = require('./StreamDispatcher');
 
 /**

src/client/voice/dispatcher/StreamDispatcher.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const VolumeInterface = require('../util/VolumeInterface');
 const { Writable } = require('stream');
 

src/client/voice/networking/VoiceUDPClient.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const udp = require('dgram');
 const { VoiceOPCodes } = require('../../../util/Constants');
 const EventEmitter = require('events');

src/client/voice/networking/VoiceWebSocket.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { OPCodes, VoiceOPCodes } = require('../../../util/Constants');
 const EventEmitter = require('events');
 const { Error } = require('../../../errors');

src/client/voice/player/AudioPlayer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const BasePlayer = require('./BasePlayer');
 
 /**

src/client/voice/player/BasePlayer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const EventEmitter = require('events').EventEmitter;
 const { Readable: ReadableStream } = require('stream');
 const prism = require('prism-media');

src/client/voice/player/BroadcastAudioPlayer.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const BroadcastDispatcher = require('../dispatcher/BroadcastDispatcher');
 const BasePlayer = require('./BasePlayer');
 

src/client/voice/receiver/PacketHandler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const secretbox = require('../util/Secretbox');
 const EventEmitter = require('events');
 

src/client/voice/receiver/Receiver.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const EventEmitter = require('events');
 const prism = require('prism-media');
 const PacketHandler = require('./PacketHandler');

src/client/voice/util/DispatcherSet.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 /**

src/client/voice/util/PlayInterface.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Readable } = require('stream');
 const prism = require('prism-media');
 const { Error } = require('../../../errors');

src/client/voice/util/Secretbox.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const libs = {
   sodium: sodium => ({
     open: sodium.api.crypto_secretbox_open_easy,

src/client/voice/util/Silence.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Readable } = require('stream');
 
 const SILENCE_FRAME = Buffer.from([0xF8, 0xFF, 0xFE]);

src/client/voice/util/VolumeInterface.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const EventEmitter = require('events');
 
 /**

src/client/websocket/WebSocketManager.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Collection = require('../../util/Collection');
 const WebSocketShard = require('./WebSocketShard');
 const { Events, Status, WSEvents } = require('../../util/Constants');

src/client/websocket/WebSocketShard.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const EventEmitter = require('events');
 const WebSocket = require('../../WebSocket');
 const { Status, Events, OPCodes, WSEvents, WSCodes } = require('../../util/Constants');

src/client/websocket/handlers/CHANNEL_CREATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.ChannelCreate.handle(packet.d);
 };

src/client/websocket/handlers/CHANNEL_DELETE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.ChannelDelete.handle(packet.d);
 };

src/client/websocket/handlers/CHANNEL_PINS_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, { d: data }) => {

src/client/websocket/handlers/CHANNEL_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, packet) => {

src/client/websocket/handlers/GUILD_BAN_ADD.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, { d: data }) => {

src/client/websocket/handlers/GUILD_BAN_REMOVE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildBanRemove.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_CREATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events, Status } = require('../../../util/Constants');
 
 module.exports = async (client, { d: data }, shard) => {

src/client/websocket/handlers/GUILD_DELETE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildDelete.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_EMOJIS_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildEmojisUpdate.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_INTEGRATIONS_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildIntegrationsUpdate.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_MEMBERS_CHUNK.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 const Collection = require('../../../util/Collection');
 

src/client/websocket/handlers/GUILD_MEMBER_ADD.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events, Status } = require('../../../util/Constants');
 
 module.exports = (client, { d: data }, shard) => {

src/client/websocket/handlers/GUILD_MEMBER_REMOVE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet, shard) => {
   client.actions.GuildMemberRemove.handle(packet.d, shard);
 };

src/client/websocket/handlers/GUILD_MEMBER_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Status, Events } = require('../../../util/Constants');
 
 module.exports = (client, { d: data }, shard) => {

src/client/websocket/handlers/GUILD_ROLE_CREATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildRoleCreate.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_ROLE_DELETE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildRoleDelete.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_ROLE_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildRoleUpdate.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_SYNC.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildSync.handle(packet.d);
 };

src/client/websocket/handlers/GUILD_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.GuildUpdate.handle(packet.d);
 };

src/client/websocket/handlers/MESSAGE_CREATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.MessageCreate.handle(packet.d);
 };

src/client/websocket/handlers/MESSAGE_DELETE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.MessageDelete.handle(packet.d);
 };

src/client/websocket/handlers/MESSAGE_DELETE_BULK.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.MessageDeleteBulk.handle(packet.d);
 };

src/client/websocket/handlers/MESSAGE_REACTION_ADD.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, packet) => {

src/client/websocket/handlers/MESSAGE_REACTION_REMOVE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.MessageReactionRemove.handle(packet.d);
 };

src/client/websocket/handlers/MESSAGE_REACTION_REMOVE_ALL.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.MessageReactionRemoveAll.handle(packet.d);
 };

src/client/websocket/handlers/MESSAGE_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, packet) => {

src/client/websocket/handlers/PRESENCE_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.PresenceUpdate.handle(packet.d);
 };

src/client/websocket/handlers/READY.js

@@ -1,3 +1,5 @@
+'use strict';
+
 let ClientUser;
 
 module.exports = (client, { d: data }, shard) => {

src/client/websocket/handlers/RESUMED.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, packet, shard) => {

src/client/websocket/handlers/TYPING_START.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { Events } = require('../../../util/Constants');
 
 module.exports = (client, { d: data }) => {

src/client/websocket/handlers/USER_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.UserUpdate.handle(packet.d);
 };

src/client/websocket/handlers/VOICE_SERVER_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.emit('self.voiceServer', packet.d);
 };

src/client/websocket/handlers/VOICE_STATE_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.VoiceStateUpdate.handle(packet.d);
 };

src/client/websocket/handlers/WEBHOOKS_UPDATE.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = (client, packet) => {
   client.actions.WebhooksUpdate.handle(packet.d);
 };

src/client/websocket/handlers/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { WSEvents } = require('../../../util/Constants');
 
 const handlers = {};

src/errors/DJSError.js

@@ -1,3 +1,5 @@
+'use strict';
+
 // Heavily inspired by node's `internal/errors` module
 
 const kCode = Symbol('code');

src/errors/Messages.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const { register } = require('./DJSError');
 
 const Messages = {

src/errors/index.js

@@ -1,2 +1,4 @@
+'use strict';
+
 module.exports = require('./DJSError');
 module.exports.Messages = require('./Messages');

src/index.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const Util = require('./util/Util');
 
 module.exports = {

src/rest/APIRequest.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const querystring = require('querystring');
 const FormData = require('form-data');
 const https = require('https');

src/rest/APIRouter.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const noop = () => {}; // eslint-disable-line no-empty-function
 const methods = ['get', 'post', 'delete', 'patch', 'put'];
 const reflectors = [

src/rest/DiscordAPIError.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Represents an error from the Discord API.
  * @extends Error

src/rest/HTTPError.js

@@ -1,3 +1,5 @@
+'use strict';
+
 /**
  * Represents a HTTP error from a request.
  * @extends Error

src/rest/RESTManager.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const RequestHandler = require('./RequestHandler');
 const APIRequest = require('./APIRequest');
 const routeBuilder = require('./APIRouter');

src/rest/RequestHandler.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const DiscordAPIError = require('./DiscordAPIError');
 const HTTPError = require('./HTTPError');
 const Util = require('../util/Util');

src/sharding/Shard.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const EventEmitter = require('events');
 const path = require('path');
 const Util = require('../util/Util');