From 46167a79d7d0cac5599459a31c33b2bbcf6e06da Mon Sep 17 00:00:00 2001 From: Idris <78701338+Idris1401@users.noreply.github.com> Date: Thu, 18 May 2023 12:13:19 +0200 Subject: [PATCH] refactor(GuildMember): make `_roles` property non-enumerable (#9387) * refactor(GuildMember): make _roles a getter and roles a normal prop * fix: revert changes * fix: requested changes * fix: requested changes --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> --- packages/discord.js/src/structures/GuildMember.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/discord.js/src/structures/GuildMember.js b/packages/discord.js/src/structures/GuildMember.js index 7c2aec177..3e71824f3 100644 --- a/packages/discord.js/src/structures/GuildMember.js +++ b/packages/discord.js/src/structures/GuildMember.js @@ -56,10 +56,12 @@ class GuildMember extends Base { /** * The role ids of the member + * @name GuildMember#_roles * @type {Snowflake[]} * @private */ - this._roles = []; + Object.defineProperty(this, '_roles', { value: [], writable: true }); + if (data) this._patch(data); }