Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-19 04:53:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

voice: delete receive stream immediately to prevent it being written to after end (#2678)

Browse Source
This commit is contained in:
Amish Shah
2018-08-07 17:34:01 +01:00
parent c10b4feeeb
commit 46fa9603c2
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/client/voice/networking/VoiceWebSocket.js
View File

@@ -184,7 +184,10 @@ class VoiceWebSocket extends EventEmitter {
case VoiceOPCodes.CLIENT_DISCONNECT: case VoiceOPCodes.CLIENT_DISCONNECT:
for (const receiver of this.connection.receivers) { for (const receiver of this.connection.receivers) {
const streamInfo = receiver.packets.streams.get(packet.d.user_id); const streamInfo = receiver.packets.streams.get(packet.d.user_id);
if (streamInfo) streamInfo.stream.push(null); if (streamInfo) {
receiver.packets.streams.delete(packet.d.user_id);
streamInfo.stream.push(null);
}
} }
break; break;
case VoiceOPCodes.SPEAKING: case VoiceOPCodes.SPEAKING:

5
src/client/voice/receiver/PacketHandler.js
View File

@@ -17,7 +17,10 @@ class PacketHandler extends EventEmitter {
_stoppedSpeaking(userID) { _stoppedSpeaking(userID) {
const streamInfo = this.streams.get(userID); const streamInfo = this.streams.get(userID);
if (streamInfo && streamInfo.end === 'silence') streamInfo.stream.push(null); if (streamInfo && streamInfo.end === 'silence') {
this.streams.delete(userID);
streamInfo.stream.push(null);
}
} }
makeStream(user, end) { makeStream(user, end) {