Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 19:43:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove auto shard spawn interval (Discord doesn't support such a great idea 👀)

Browse Source
This commit is contained in:
Schuyler Cebulskie
2016-10-14 00:21:08 -04:00
parent 915a4cbe37
commit 485ffd267e
2 changed files with 1 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/docs.json
View File

File diff suppressed because one or more lines are too long

22
src/sharding/ShardingManager.js
View File

@@ -18,8 +18,6 @@ class ShardingManager extends EventEmitter {
* @param {string} file Path to your shard script file * @param {string} file Path to your shard script file
* @param {Object} [options] Options for the sharding manager * @param {Object} [options] Options for the sharding manager
* @param {number|string} [options.totalShards='auto'] Number of shards to spawn, or "auto" * @param {number|string} [options.totalShards='auto'] Number of shards to spawn, or "auto"
* @param {number} [options.autoShardInterval=600] How frequently to automatically spawn another shard if needed
* (in seconds) - only applicable if `totalShards` is `auto`
* @param {boolean} [options.respawn=true] Whether shards should automatically respawn upon exiting * @param {boolean} [options.respawn=true] Whether shards should automatically respawn upon exiting
* @param {string[]} [options.shardArgs=[]] Arguments to pass to the shard script when spawning * @param {string[]} [options.shardArgs=[]] Arguments to pass to the shard script when spawning
* @param {string} [options.token] Token to use for automatic shard count and passing to shards * @param {string} [options.token] Token to use for automatic shard count and passing to shards
@@ -28,7 +26,6 @@ class ShardingManager extends EventEmitter {
super(); super();
options = mergeDefault({ options = mergeDefault({
totalShards: 'auto', totalShards: 'auto',
autoShardInterval: 600,
respawn: true, respawn: true,
shardArgs: [], shardArgs: [],
token: null, token: null,
@@ -59,16 +56,6 @@ class ShardingManager extends EventEmitter {
} }
} }
/**
* How frequently to check the recommend shard count and spawn a new shard if necessary (in seconds).
* Only applicable when `totalShards` is `auto`.
* @type {number}
*/
this.autoShardInterval = options.autoShardInterval;
if (typeof this.autoShardInterval !== 'number' || isNaN(this.autoShardInterval)) {
throw new TypeError('The autoShardInterval option must be a number.');
}
/** /**
* Whether shards should automatically respawn upon exiting * Whether shards should automatically respawn upon exiting
* @type {boolean} * @type {boolean}
@@ -92,15 +79,6 @@ class ShardingManager extends EventEmitter {
* @type {Collection<number, Shard>} * @type {Collection<number, Shard>}
*/ */
this.shards = new Collection(); this.shards = new Collection();
// Set up automatic shard creation interval
if (this.totalShards === 'auto' && this.autoShardInterval > 0) {
setInterval(() => {
getRecommendedShards(this.token).then(count => {
if (this.shards.size < count) this.createShard();
});
}, this.autoShardInterval);
}
} }
/** /**