Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-11 09:03:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove _roles from pseudo-managers (#5721)

Browse Source
This commit is contained in:
Jan
2021-06-01 23:35:11 +02:00
committed by GitHub
parent 7b85a7259f
commit 53d952a4ce
2 changed files with 14 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/managers/GuildEmojiRoleManager.js
View File

@@ -26,23 +26,13 @@ class GuildEmojiRoleManager {
Object.defineProperty(this, 'client', { value: emoji.client });
}
/**
* The filtered collection of roles of the guild emoji
* @type {Collection<Snowflake, Role>}
* @private
* @readonly
*/
get _roles() {
return this.guild.roles.cache.filter(role => this.emoji._roles.includes(role.id));
}
/**
* The cache of roles belonging to this emoji
* @type {Collection<Snowflake, Role>}
* @readonly
*/
get cache() {
return this._roles;
return this.guild.roles.cache.filter(role => this.emoji._roles.includes(role.id));
}
/**
@@ -62,7 +52,7 @@ class GuildEmojiRoleManager {
resolvedRoles.push(resolvedRole);
}
const newRoles = [...new Set(resolvedRoles.concat(...this._roles.values()))];
const newRoles = [...new Set(resolvedRoles.concat(...this.cache.values()))];
return this.set(newRoles);
}
@@ -83,7 +73,7 @@ class GuildEmojiRoleManager {
resolvedRoleIDs.push(roleID);
}
const newRoles = this._roles.keyArray().filter(id => !resolvedRoleIDs.includes(id));
const newRoles = this.cache.keyArray().filter(id => !resolvedRoleIDs.includes(id));
return this.set(newRoles);
}
@@ -108,7 +98,7 @@ class GuildEmojiRoleManager {
clone() {
const clone = new this.constructor(this.emoji);
clone._patch(this._roles.keyArray().slice());
clone._patch(this.cache.keyArray().slice());
return clone;
}