Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 19:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

types: fix regressions (#7649)

Browse Source 
* types: fix regressions

* fix: make requested changes

* Apply suggestions from code review

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

* types: action row data should take builders

* types: remove redundant overload

* fix(MessagePayload): ensure components are serialized correctly

* fix(MessagePayload): don't always create new action row

* refactor(UnsafeModalBuilder): make data public

* types: use type union

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

* types: fix types and add tests

Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
This commit is contained in:
Rodry
2022-04-03 23:19:44 +01:00
committed by GitHub
parent ac4bc3a6c8
commit 5748dbe087
8 changed files with 52 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/builders/src/components/ActionRow.ts
View File

@@ -34,7 +34,7 @@ export class ActionRowBuilder<
/**
* The components within this action row
*/
private readonly components: T[];
public readonly components: T[];
public constructor({
components,

2
packages/builders/src/components/selectMenu/UnsafeSelectMenu.ts
View File

@@ -11,7 +11,7 @@ export class UnsafeSelectMenuBuilder extends ComponentBuilder<
/**
* The options within this select menu
*/
protected readonly options: UnsafeSelectMenuOptionBuilder[];
public readonly options: UnsafeSelectMenuOptionBuilder[];
public constructor(data?: Partial<APISelectMenuComponent>) {
const { options, ...initData } = data ?? {};

2
packages/builders/src/interactions/modals/UnsafeModal.ts
View File

@@ -6,7 +6,7 @@ import type {
import { ActionRowBuilder, createComponentBuilder, JSONEncodable, ModalActionRowComponentBuilder } from '../../index';
export class UnsafeModalBuilder implements JSONEncodable<APIModalInteractionResponseCallbackData> {
protected readonly data: Partial<Omit<APIModalInteractionResponseCallbackData, 'components'>>;
public readonly data: Partial<Omit<APIModalInteractionResponseCallbackData, 'components'>>;
public readonly components: ActionRowBuilder<ModalActionRowComponentBuilder>[] = [];
public constructor({ components, ...data }: Partial<APIModalInteractionResponseCallbackData> = {}) {