From 58bbcd591e01894594dffba8bdafb95c99670fb1 Mon Sep 17 00:00:00 2001 From: DTrombett <73136330+DTrombett@users.noreply.github.com> Date: Wed, 7 Jul 2021 14:41:47 +0200 Subject: [PATCH] types(ApplicationCommand): fix option name (#6067) * types(ApplicationCommand): fix option name * fix(ApplicationCommand): update tests * fix(ApplicationCommand): fix error param --- .../ApplicationCommandPermissionsManager.js | 2 +- typings/index.d.ts | 2 +- typings/index.ts | 30 +++++++++---------- 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/src/managers/ApplicationCommandPermissionsManager.js b/src/managers/ApplicationCommandPermissionsManager.js index 367ce50b7..71648f250 100644 --- a/src/managers/ApplicationCommandPermissionsManager.js +++ b/src/managers/ApplicationCommandPermissionsManager.js @@ -347,7 +347,7 @@ class ApplicationCommandPermissionsManager extends BaseManager { const { guildId, commandId } = this._validateOptions(guild, command); if (!commandId) throw new TypeError('INVALID_TYPE', 'command', 'ApplicationCommandResolvable'); - if (!permissionId) throw new TypeError('INVALID_TYPE', 'permissionsId', 'UserResolvable or RoleResolvable'); + if (!permissionId) throw new TypeError('INVALID_TYPE', 'permissionId', 'UserResolvable or RoleResolvable'); let resolvedId = permissionId; if (typeof permissionId !== 'string') { resolvedId = this.client.users.resolveId(permissionId); diff --git a/typings/index.d.ts b/typings/index.d.ts index 634c97429..38a403bed 100644 --- a/typings/index.d.ts +++ b/typings/index.d.ts @@ -2120,7 +2120,7 @@ export class ApplicationCommandPermissionsManager< public add( options: FetchSingleOptions & { permissions: ApplicationCommandPermissionData[] }, ): Promise; - public has(options: FetchSingleOptions & { permissionsId: UserResolvable | RoleResolvable }): Promise; + public has(options: FetchSingleOptions & { permissionId: UserResolvable | RoleResolvable }): Promise; public fetch(options: FetchSingleOptions): Promise; public fetch(options: BaseOptions): Promise>; public remove( diff --git a/typings/index.ts b/typings/index.ts index 0ab4c2bd8..d03f898f3 100644 --- a/typings/index.ts +++ b/typings/index.ts @@ -60,7 +60,7 @@ client.on('ready', async () => { guild: testGuildId, permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); - await globalPermissionsManager?.has({ command: globalCommandId, guild: testGuildId, permissionsId: testGuildId }); + await globalPermissionsManager?.has({ command: globalCommandId, guild: testGuildId, permissionId: testGuildId }); await globalPermissionsManager?.fetch({ guild: testGuildId }); await globalPermissionsManager?.fetch({ command: globalCommandId, guild: testGuildId }); await globalPermissionsManager?.remove({ command: globalCommandId, guild: testGuildId, roles: [testGuildId] }); @@ -87,7 +87,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await globalPermissionsManager?.has({ command: globalCommandId, permissionsId: testGuildId }); + await globalPermissionsManager?.has({ command: globalCommandId, permissionId: testGuildId }); // @ts-expect-error await globalPermissionsManager?.fetch(); // @ts-expect-error @@ -120,7 +120,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await globalPermissionsManager?.has({ guild: testGuildId, permissionsId: testGuildId }); + await globalPermissionsManager?.has({ guild: testGuildId, permissionId: testGuildId }); // @ts-expect-error await globalPermissionsManager?.remove({ guild: testGuildId, roles: [testGuildId] }); // @ts-expect-error @@ -138,7 +138,7 @@ client.on('ready', async () => { command: globalCommandId, permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); - await guildPermissionsManager?.has({ command: globalCommandId, permissionsId: testGuildId }); + await guildPermissionsManager?.has({ command: globalCommandId, permissionId: testGuildId }); await guildPermissionsManager?.fetch({}); await guildPermissionsManager?.fetch({ command: globalCommandId }); await guildPermissionsManager?.remove({ command: globalCommandId, roles: [testGuildId] }); @@ -159,7 +159,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await guildPermissionsManager?.has({ command: globalCommandId, guild: testGuildId, permissionsId: testGuildId }); + await guildPermissionsManager?.has({ command: globalCommandId, guild: testGuildId, permissionId: testGuildId }); // @ts-expect-error await guildPermissionsManager?.fetch({ guild: testGuildId }); // @ts-expect-error @@ -190,7 +190,7 @@ client.on('ready', async () => { // @ts-expect-error await guildPermissionsManager?.add({ permissions: [{ type: 'ROLE', id: testGuildId, permission: true }] }); // @ts-expect-error - await guildPermissionsManager?.has({ permissionsId: testGuildId }); + await guildPermissionsManager?.has({ permissionId: testGuildId }); // @ts-expect-error await guildPermissionsManager?.remove({ roles: [testGuildId] }); // @ts-expect-error @@ -210,7 +210,7 @@ client.on('ready', async () => { guild: testGuildId, permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); - await globalCommand?.permissions.has({ guild: testGuildId, permissionsId: testGuildId }); + await globalCommand?.permissions.has({ guild: testGuildId, permissionId: testGuildId }); await globalCommand?.permissions.fetch({ guild: testGuildId }); await globalCommand?.permissions.remove({ guild: testGuildId, roles: [testGuildId] }); await globalCommand?.permissions.remove({ guild: testGuildId, users: [testUserId] }); @@ -227,7 +227,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await globalCommand?.permissions.has({ command: globalCommandId, guild: testGuildId, permissionsId: testGuildId }); + await globalCommand?.permissions.has({ command: globalCommandId, guild: testGuildId, permissionId: testGuildId }); // @ts-expect-error await globalCommand?.permissions.fetch({ command: globalCommandId, guild: testGuildId }); // @ts-expect-error @@ -251,7 +251,7 @@ client.on('ready', async () => { // @ts-expect-error await globalCommand?.permissions.add({ permissions: [{ type: 'ROLE', id: testGuildId, permission: true }] }); // @ts-expect-error - await globalCommand?.permissions.has({ permissionsId: testGuildId }); + await globalCommand?.permissions.has({ permissionId: testGuildId }); // @ts-expect-error await globalCommand?.permissions.fetch({}); // @ts-expect-error @@ -265,7 +265,7 @@ client.on('ready', async () => { // Permissions from cached guild ApplicationCommand await guildCommandFromGlobal?.permissions.add({ permissions: [{ type: 'ROLE', id: testGuildId, permission: true }] }); - await guildCommandFromGlobal?.permissions.has({ permissionsId: testGuildId }); + await guildCommandFromGlobal?.permissions.has({ permissionId: testGuildId }); await guildCommandFromGlobal?.permissions.fetch({}); await guildCommandFromGlobal?.permissions.remove({ roles: [testGuildId] }); await guildCommandFromGlobal?.permissions.remove({ users: [testUserId] }); @@ -278,7 +278,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await guildCommandFromGlobal?.permissions.has({ command: guildCommandId, permissionsId: testGuildId }); + await guildCommandFromGlobal?.permissions.has({ command: guildCommandId, permissionId: testGuildId }); // @ts-expect-error await guildCommandFromGlobal?.permissions.remove({ command: guildCommandId, roles: [testGuildId] }); // @ts-expect-error @@ -301,7 +301,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await guildCommandFromGlobal?.permissions.has({ guild: testGuildId, permissionsId: testGuildId }); + await guildCommandFromGlobal?.permissions.has({ guild: testGuildId, permissionId: testGuildId }); // @ts-expect-error await guildCommandFromGlobal?.permissions.remove({ guild: testGuildId, roles: [testGuildId] }); // @ts-expect-error @@ -315,7 +315,7 @@ client.on('ready', async () => { }); await guildCommandFromGuild?.permissions.add({ permissions: [{ type: 'ROLE', id: testGuildId, permission: true }] }); - await guildCommandFromGuild?.permissions.has({ permissionsId: testGuildId }); + await guildCommandFromGuild?.permissions.has({ permissionId: testGuildId }); await guildCommandFromGuild?.permissions.fetch({}); await guildCommandFromGuild?.permissions.remove({ roles: [testGuildId] }); await guildCommandFromGuild?.permissions.remove({ users: [testUserId] }); @@ -328,7 +328,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await guildCommandFromGuild?.permissions.has({ command: guildCommandId, permissionsId: testGuildId }); + await guildCommandFromGuild?.permissions.has({ command: guildCommandId, permissionId: testGuildId }); // @ts-expect-error await guildCommandFromGuild?.permissions.remove({ command: guildCommandId, roles: [testGuildId] }); // @ts-expect-error @@ -351,7 +351,7 @@ client.on('ready', async () => { permissions: [{ type: 'ROLE', id: testGuildId, permission: true }], }); // @ts-expect-error - await guildCommandFromGuild?.permissions.has({ guild: testGuildId, permissionsId: testGuildId }); + await guildCommandFromGuild?.permissions.has({ guild: testGuildId, permissionId: testGuildId }); // @ts-expect-error await guildCommandFromGuild?.permissions.remove({ guild: testGuildId, roles: [testGuildId] }); // @ts-expect-error