From 5cbdf380289f0fd1d16330325dab71f8815396fc Mon Sep 17 00:00:00 2001 From: Will Nelson Date: Fri, 21 Dec 2018 23:49:56 -0800 Subject: [PATCH] fix(WebSocketShard): add websocket send error handling (#2981) * websocket send error handling * fix: emit only when error is present * refactor: use an if instead --- src/client/websocket/WebSocketShard.js | 4 +++- test/tester1000.js | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/client/websocket/WebSocketShard.js b/src/client/websocket/WebSocketShard.js index 6237b0516..ea4595b41 100644 --- a/src/client/websocket/WebSocketShard.js +++ b/src/client/websocket/WebSocketShard.js @@ -437,7 +437,9 @@ class WebSocketShard extends EventEmitter { this.debug(`Tried to send packet ${data} but no WebSocket is available!`); return; } - this.ws.send(WebSocket.pack(data)); + this.ws.send(WebSocket.pack(data), err => { + if (err) this.manager.client.emit(Events.ERROR, err); + }); } /** diff --git a/test/tester1000.js b/test/tester1000.js index d726188c5..f9d7f668d 100644 --- a/test/tester1000.js +++ b/test/tester1000.js @@ -13,6 +13,7 @@ client.on('ready', () => { log('READY', client.user.tag, client.user.id); }); client.on('rateLimit', log); +client.on('error', console.error); const commands = { eval: message => {