refactor(MessageReaction): ReactionUserStore (#2078)

* refactor(MessageReactions): fetchUsers() is now users.fetch()

made a lovely class for it and all
happify linter


stuff


i know how to code i swear


i lied

* bdistin suggestions

* space suggestions, rename store

* fix count

* documentation update
This commit is contained in:
Isabella
2017-11-14 02:11:44 -06:00
committed by Amish Shah
parent 62544905a0
commit 5cd42695ae
3 changed files with 37 additions and 23 deletions

View File

@@ -1,6 +1,6 @@
const Collection = require('../util/Collection');
const Emoji = require('./Emoji');
const ReactionEmoji = require('./ReactionEmoji');
const ReactionUserStore = require('../stores/ReactionUserStore');
const { Error } = require('../errors');
/**
@@ -28,9 +28,9 @@ class MessageReaction {
/**
* The users that have given this reaction, mapped by their ID
* @type {Collection<Snowflake, User>}
* @type {ReactionUserStore<Snowflake, User>}
*/
this.users = new Collection();
this.users = new ReactionUserStore(client, undefined, this);
this._emoji = new ReactionEmoji(this, data.emoji.name, data.emoji.id);
}
@@ -77,26 +77,6 @@ class MessageReaction {
);
}
/**
* Fetches all the users that gave this reaction. Resolves with a collection of users, mapped by their IDs.
* @param {Object} [options] Options for fetching the users
* @param {number} [options.limit=100] The maximum amount of users to fetch, defaults to 100
* @param {Snowflake} [options.after] Limit fetching users to those with an id greater than the supplied id
* @returns {Promise<Collection<Snowflake, User>>}
*/
async fetchUsers({ limit = 100, after } = {}) {
const message = this.message;
const users = await message.client.api.channels[message.channel.id].messages[message.id]
.reactions[this.emoji.identifier]
.get({ query: { limit, after } });
for (const rawUser of users) {
const user = message.client.users.create(rawUser);
this.users.set(user.id, user);
}
this.count = this.users.size;
return this.users;
}
_add(user) {
if (!this.users.has(user.id)) {
this.users.set(user.id, user);