From 5cdd5d76ed19344161abcc767c48ef7aeb058c54 Mon Sep 17 00:00:00 2001
From: iCrawl <buechler.noel@outlook.com>
Date: Mon, 27 Mar 2023 20:43:34 +0200
Subject: [PATCH] fix(website): page height to hide footer without scrolling

---
 apps/guide/src/components/Navbar.tsx                          | 2 +-
 apps/guide/src/components/Sidebar.tsx                         | 2 +-
 .../src/app/docs/packages/[package]/[version]/[item]/page.tsx | 4 +++-
 .../src/app/docs/packages/[package]/[version]/layout.tsx      | 4 ++--
 apps/website/src/components/Header.tsx                        | 2 +-
 apps/website/src/components/Nav.tsx                           | 2 +-
 6 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/apps/guide/src/components/Navbar.tsx b/apps/guide/src/components/Navbar.tsx
index 7b1c9804b..f11211660 100644
--- a/apps/guide/src/components/Navbar.tsx
+++ b/apps/guide/src/components/Navbar.tsx
@@ -19,7 +19,7 @@ export function Navbar({ pages }: { pages?: MDXPage[] | undefined }) {
 	return (
 		<>
 			<header className="dark:bg-dark-400 dark:border-dark-100 bg-light-600 border-light-800 fixed top-0 left-0 z-20 w-full border-b">
-				<div className="h-18 block px-6">
+				<div className="block h-16 px-6">
 					<div className="flex h-full flex-row place-content-between place-items-center">
 						<Button
 							aria-label="Menu"
diff --git a/apps/guide/src/components/Sidebar.tsx b/apps/guide/src/components/Sidebar.tsx
index 75dd5c108..2eebc0222 100644
--- a/apps/guide/src/components/Sidebar.tsx
+++ b/apps/guide/src/components/Sidebar.tsx
@@ -4,7 +4,7 @@ import type { MDXPage } from './SidebarItems.jsx';
 export function Sidebar({ pages, opened }: { opened: boolean; pages?: MDXPage[] | undefined }) {
 	return (
 		<nav
-			className={`h-[calc(100vh - 73px)] dark:bg-dark-600 dark:border-dark-100 border-light-800 fixed top-[73px] left-0 bottom-0 z-20 w-full border-r bg-white ${
+			className={`h-[calc(100vh - 65px)] dark:bg-dark-600 dark:border-dark-100 border-light-800 fixed top-[65px] left-0 bottom-0 z-20 w-full border-r bg-white ${
 				opened ? 'block' : 'hidden'
 			} lg:w-76 lg:max-w-76 lg:block`}
 		>
diff --git a/apps/website/src/app/docs/packages/[package]/[version]/[item]/page.tsx b/apps/website/src/app/docs/packages/[package]/[version]/[item]/page.tsx
index 6c15ab9b7..dabc8f851 100644
--- a/apps/website/src/app/docs/packages/[package]/[version]/[item]/page.tsx
+++ b/apps/website/src/app/docs/packages/[package]/[version]/[item]/page.tsx
@@ -181,7 +181,9 @@ export default async function Page({ params }: { params: ItemRouteParams }) {
 			}
 		>
 			<article className="dark:bg-dark-800 bg-light-600">
-				<div className="dark:bg-dark-600 bg-white p-6 pb-20 shadow">{member ? <Member member={member} /> : null}</div>
+				<div className="dark:bg-dark-600 min-h-[calc(100vh_-_64px)] bg-white p-6 pb-20 shadow">
+					{member ? <Member member={member} /> : null}
+				</div>
 			</article>
 		</div>
 	);
diff --git a/apps/website/src/app/docs/packages/[package]/[version]/layout.tsx b/apps/website/src/app/docs/packages/[package]/[version]/layout.tsx
index aa7feeab8..c0a361285 100644
--- a/apps/website/src/app/docs/packages/[package]/[version]/layout.tsx
+++ b/apps/website/src/app/docs/packages/[package]/[version]/layout.tsx
@@ -72,8 +72,8 @@ export default async function PackageLayout({ children, params }: PropsWithChild
 			<main>
 				<Header />
 				<Nav members={members.map((member) => serializeIntoSidebarItemData(member))} />
-				<article className="pt-18 lg:pl-76">
-					<div className="relative z-10 min-h-[calc(100vh_-_70px)]">{children}</div>
+				<article className="lg:pl-76 pt-16">
+					<div className="relative z-10">{children}</div>
 					<div className="h-76 md:h-52" />
 				</article>
 				<Footer />
diff --git a/apps/website/src/components/Header.tsx b/apps/website/src/components/Header.tsx
index 13e789819..5ebd40512 100644
--- a/apps/website/src/components/Header.tsx
+++ b/apps/website/src/components/Header.tsx
@@ -65,7 +65,7 @@ export default function Header() {
 
 	return (
 		<header className="dark:bg-dark-400 dark:border-dark-100 bg-light-600 border-light-800 fixed top-0 left-0 z-20 w-full border-b">
-			<div className="h-18 block px-6">
+			<div className="block h-16 px-6">
 				<div className="flex h-full flex-row place-content-between place-items-center">
 					<Button
 						aria-label="Menu"
diff --git a/apps/website/src/components/Nav.tsx b/apps/website/src/components/Nav.tsx
index f5219a91b..a8df6f4b2 100644
--- a/apps/website/src/components/Nav.tsx
+++ b/apps/website/src/components/Nav.tsx
@@ -14,7 +14,7 @@ export function Nav({ members }: { members: SidebarSectionItemData[] }) {
 
 	return (
 		<nav
-			className={`dark:bg-dark-600 dark:border-dark-100 border-light-800 fixed top-[73px] left-0 bottom-0 z-20 h-[calc(100vh_-_73px)] w-full border-r bg-white ${
+			className={`dark:bg-dark-600 dark:border-dark-100 border-light-800 fixed top-[65px] left-0 bottom-0 z-20 h-[calc(100vh_-_65px)] w-full border-r bg-white ${
 				opened ? 'block' : 'hidden'
 			} lg:w-76 lg:max-w-76 lg:block`}
 		>