Errors Standardization (#1246)

* errors and stuff

* more errors

* all the errors

* fix build

src/client/voice/ClientVoiceManager.js

@@ -1,5 +1,6 @@
 const Collection = require('../../util/Collection');
 const VoiceConnection = require('./VoiceConnection');
+const { Error } = require('../../errors');
 
 /**
  * Manages all the voice stuff for the client.
@@ -44,11 +45,7 @@ class ClientVoiceManager {
   joinChannel(channel) {
     return new Promise((resolve, reject) => {
       if (!channel.joinable) {
-        if (channel.full) {
-          throw new Error('You do not have permission to join this voice channel; it is full.');
-        } else {
-          throw new Error('You do not have permission to join this voice channel.');
-        }
+        throw new Error('VOICE_JOIN_CHANNEL', channel.full);
       }
 
       let connection = this.connections.get(channel.guild.id);

src/client/voice/VoiceConnection.js

@@ -6,6 +6,7 @@ const AudioPlayer = require('./player/AudioPlayer');
 const VoiceReceiver = require('./receiver/VoiceReceiver');
 const EventEmitter = require('events').EventEmitter;
 const Prism = require('prism-media');
+const { Error } = require('../../errors');
 
 /**
  * Represents a connection to a guild's voice server.
@@ -341,8 +342,8 @@ class VoiceConnection extends EventEmitter {
    */
   connect() {
     if (this.status !== Constants.VoiceStatus.RECONNECTING) {
-      if (this.sockets.ws) throw new Error('There is already an existing WebSocket connection.');
-      if (this.sockets.udp) throw new Error('There is already an existing UDP connection.');
+      if (this.sockets.ws) throw new Error('WS_CONNECTION_EXISTS');
+      if (this.sockets.udp) throw new Error('UDP_CONNECTION_EXISTS');
     }
 
     if (this.sockets.ws) this.sockets.ws.shutdown();

src/client/voice/VoiceUDPClient.js

@@ -2,6 +2,7 @@ const udp = require('dgram');
 const dns = require('dns');
 const Constants = require('../../util/Constants');
 const EventEmitter = require('events').EventEmitter;
+const { Error } = require('../../errors');
 
 /**
  * Represents a UDP client for a Voice Connection.
@@ -89,8 +90,8 @@ class VoiceConnectionUDPClient extends EventEmitter {
    */
   send(packet) {
     return new Promise((resolve, reject) => {
-      if (!this.socket) throw new Error('Tried to send a UDP packet, but there is no socket available.');
-      if (!this.discordAddress || !this.discordPort) throw new Error('Malformed UDP address or port.');
+      if (!this.socket) throw new Error('UDP_SEND_FAIL');
+      if (!this.discordAddress || !this.discordPort) throw new Error('UDP_ADDRESS_MALFORMED');
       this.socket.send(packet, 0, packet.length, this.discordPort, this.discordAddress, error => {
         if (error) reject(error); else resolve(packet);
       });

src/client/voice/VoiceWebSocket.js

@@ -1,6 +1,7 @@
 const Constants = require('../../util/Constants');
 const SecretKey = require('./util/SecretKey');
 const EventEmitter = require('events').EventEmitter;
+const { Error } = require('../../errors');
 
 let WebSocket;
 try {
@@ -88,9 +89,7 @@ class VoiceWebSocket extends EventEmitter {
    */
   send(data) {
     return new Promise((resolve, reject) => {
-      if (!this.ws || this.ws.readyState !== WebSocket.OPEN) {
-        throw new Error(`Voice websocket not open to send ${data}.`);
-      }
+      if (!this.ws || this.ws.readyState !== WebSocket.OPEN) throw new Error('WS_NOT_OPEN', data);
       this.ws.send(data, null, error => {
         if (error) reject(error); else resolve(data);
       });

src/client/voice/opus/OpusEngineList.js

@@ -1,3 +1,5 @@
+const { Error } = require('../../../errors');
+
 const list = [
   require('./NodeOpusEngine'),
   require('./OpusScriptEngine'),
@@ -30,5 +32,5 @@ exports.fetch = engineOptions => {
 
 exports.guaranteeOpusEngine = () => {
   if (typeof opusEngineFound === 'undefined') opusEngineFound = Boolean(exports.fetch());
-  if (!opusEngineFound) throw new Error('Couldn\'t find an Opus engine.');
+  if (!opusEngineFound) throw new Error('OPUS_ENGINE_MISSING');
 };

src/client/voice/receiver/VoiceReceiver.js

@@ -2,6 +2,7 @@ const EventEmitter = require('events').EventEmitter;
 const secretbox = require('../util/Secretbox');
 const Readable = require('./VoiceReadable');
 const OpusEncoders = require('../opus/OpusEngineList');
+const { Error } = require('../../../errors');
 
 const nonce = Buffer.alloc(24);
 nonce.fill(0);
@@ -122,8 +123,8 @@ class VoiceReceiver extends EventEmitter {
    */
   createOpusStream(user) {
     user = this.voiceConnection.voiceManager.client.resolver.resolveUser(user);
-    if (!user) throw new Error('Couldn\'t resolve the user to create Opus stream.');
-    if (this.opusStreams.get(user.id)) throw new Error('There is already an existing stream for that user.');
+    if (!user) throw new Error('VOICE_USER_MISSING');
+    if (this.opusStreams.get(user.id)) throw new Error('VOICE_STREAM_EXISTS');
     const stream = new Readable();
     this.opusStreams.set(user.id, stream);
     return stream;
@@ -137,8 +138,8 @@ class VoiceReceiver extends EventEmitter {
    */
   createPCMStream(user) {
     user = this.voiceConnection.voiceManager.client.resolver.resolveUser(user);
-    if (!user) throw new Error('Couldn\'t resolve the user to create PCM stream.');
-    if (this.pcmStreams.get(user.id)) throw new Error('There is already an existing stream for that user.');
+    if (!user) throw new Error('VOICE_USER_MISSING');
+    if (this.pcmStreams.get(user.id)) throw new Error('VOICE_STREAM_EXISTS');
     const stream = new Readable();
     this.pcmStreams.set(user.id, stream);
     return stream;