refactor(sharding): use switch statement (#8928)

This commit is contained in:
Tristan Camejo
2022-12-15 19:07:28 +11:00
committed by GitHub
parent 627511d652
commit 6540914b4a
2 changed files with 60 additions and 45 deletions

View File

@@ -21,8 +21,14 @@ class Shard extends EventEmitter {
constructor(manager, id) { constructor(manager, id) {
super(); super();
if (manager.mode === 'process') childProcess = require('node:child_process'); switch (manager.mode) {
else if (manager.mode === 'worker') Worker = require('node:worker_threads').Worker; case 'process':
childProcess = require('node:child_process');
break;
case 'worker':
Worker = require('node:worker_threads').Worker;
break;
}
/** /**
* Manager that created the shard * Manager that created the shard
@@ -112,7 +118,8 @@ class Shard extends EventEmitter {
this._exitListener = this._handleExit.bind(this, undefined, timeout); this._exitListener = this._handleExit.bind(this, undefined, timeout);
if (this.manager.mode === 'process') { switch (this.manager.mode) {
case 'process':
this.process = childProcess this.process = childProcess
.fork(path.resolve(this.manager.file), this.args, { .fork(path.resolve(this.manager.file), this.args, {
env: this.env, env: this.env,
@@ -120,10 +127,12 @@ class Shard extends EventEmitter {
}) })
.on('message', this._handleMessage.bind(this)) .on('message', this._handleMessage.bind(this))
.on('exit', this._exitListener); .on('exit', this._exitListener);
} else if (this.manager.mode === 'worker') { break;
case 'worker':
this.worker = new Worker(path.resolve(this.manager.file), { workerData: this.env }) this.worker = new Worker(path.resolve(this.manager.file), { workerData: this.env })
.on('message', this._handleMessage.bind(this)) .on('message', this._handleMessage.bind(this))
.on('exit', this._exitListener); .on('exit', this._exitListener);
break;
} }
this._evals.clear(); this._evals.clear();

View File

@@ -29,7 +29,8 @@ class ShardClientUtil {
*/ */
this.parentPort = null; this.parentPort = null;
if (mode === 'process') { switch (mode) {
case 'process':
process.on('message', this._handleMessage.bind(this)); process.on('message', this._handleMessage.bind(this));
client.on('ready', () => { client.on('ready', () => {
process.send({ _ready: true }); process.send({ _ready: true });
@@ -40,7 +41,8 @@ class ShardClientUtil {
client.on('reconnecting', () => { client.on('reconnecting', () => {
process.send({ _reconnecting: true }); process.send({ _reconnecting: true });
}); });
} else if (mode === 'worker') { break;
case 'worker':
this.parentPort = require('node:worker_threads').parentPort; this.parentPort = require('node:worker_threads').parentPort;
this.parentPort.on('message', this._handleMessage.bind(this)); this.parentPort.on('message', this._handleMessage.bind(this));
client.on('ready', () => { client.on('ready', () => {
@@ -52,6 +54,7 @@ class ShardClientUtil {
client.on('reconnecting', () => { client.on('reconnecting', () => {
this.parentPort.postMessage({ _reconnecting: true }); this.parentPort.postMessage({ _reconnecting: true });
}); });
break;
} }
} }
@@ -81,14 +84,17 @@ class ShardClientUtil {
*/ */
send(message) { send(message) {
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
if (this.mode === 'process') { switch (this.mode) {
case 'process':
process.send(message, err => { process.send(message, err => {
if (err) reject(err); if (err) reject(err);
else resolve(); else resolve();
}); });
} else if (this.mode === 'worker') { break;
case 'worker':
this.parentPort.postMessage(message); this.parentPort.postMessage(message);
resolve(); resolve();
break;
} }
}); });
} }