refactor(sharding): use switch statement (#8928)

packages/discord.js/src/sharding/Shard.js

@@ -21,8 +21,14 @@ class Shard extends EventEmitter {
   constructor(manager, id) {
     super();
 
-    if (manager.mode === 'process') childProcess = require('node:child_process');
-    else if (manager.mode === 'worker') Worker = require('node:worker_threads').Worker;
+    switch (manager.mode) {
+      case 'process':
+        childProcess = require('node:child_process');
+        break;
+      case 'worker':
+        Worker = require('node:worker_threads').Worker;
+        break;
+    }
 
     /**
      * Manager that created the shard
@@ -112,7 +118,8 @@ class Shard extends EventEmitter {
 
     this._exitListener = this._handleExit.bind(this, undefined, timeout);
 
-    if (this.manager.mode === 'process') {
+    switch (this.manager.mode) {
+      case 'process':
         this.process = childProcess
           .fork(path.resolve(this.manager.file), this.args, {
             env: this.env,
@@ -120,10 +127,12 @@ class Shard extends EventEmitter {
           })
           .on('message', this._handleMessage.bind(this))
           .on('exit', this._exitListener);
-    } else if (this.manager.mode === 'worker') {
+        break;
+      case 'worker':
         this.worker = new Worker(path.resolve(this.manager.file), { workerData: this.env })
           .on('message', this._handleMessage.bind(this))
           .on('exit', this._exitListener);
+        break;
     }
 
     this._evals.clear();

packages/discord.js/src/sharding/ShardClientUtil.js

@@ -29,7 +29,8 @@ class ShardClientUtil {
      */
     this.parentPort = null;
 
-    if (mode === 'process') {
+    switch (mode) {
+      case 'process':
         process.on('message', this._handleMessage.bind(this));
         client.on('ready', () => {
           process.send({ _ready: true });
@@ -40,7 +41,8 @@ class ShardClientUtil {
         client.on('reconnecting', () => {
           process.send({ _reconnecting: true });
         });
-    } else if (mode === 'worker') {
+        break;
+      case 'worker':
         this.parentPort = require('node:worker_threads').parentPort;
         this.parentPort.on('message', this._handleMessage.bind(this));
         client.on('ready', () => {
@@ -52,6 +54,7 @@ class ShardClientUtil {
         client.on('reconnecting', () => {
           this.parentPort.postMessage({ _reconnecting: true });
         });
+        break;
     }
   }
 
@@ -81,14 +84,17 @@ class ShardClientUtil {
    */
   send(message) {
     return new Promise((resolve, reject) => {
-      if (this.mode === 'process') {
+      switch (this.mode) {
+        case 'process':
           process.send(message, err => {
             if (err) reject(err);
             else resolve();
           });
-      } else if (this.mode === 'worker') {
+          break;
+        case 'worker':
           this.parentPort.postMessage(message);
           resolve();
+          break;
       }
     });
   }