From 68dd260dee1a7b0bbd4fcdff1b39283ea8dcedec Mon Sep 17 00:00:00 2001 From: Naiyar <137700126+imnaiyar@users.noreply.github.com> Date: Tue, 14 Jan 2025 20:16:33 +0600 Subject: [PATCH] types: Allow only ephemeral for defer reply (#10696) * fix(types): remove unusable flags from InteractionDeferReplyOptions * fix: include flags in WebhookMessageEditOptions * chore: update jsdoc * fix: wrong order * chore: specify the flag * chore: extend MessageEditOptions --------- Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> --- packages/discord.js/src/structures/Webhook.js | 3 +-- packages/discord.js/typings/index.d.ts | 7 ++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/discord.js/src/structures/Webhook.js b/packages/discord.js/src/structures/Webhook.js index dd25282fb..5e529ebb3 100644 --- a/packages/discord.js/src/structures/Webhook.js +++ b/packages/discord.js/src/structures/Webhook.js @@ -141,8 +141,7 @@ class Webhook { /** * Options that can be passed into editMessage. - * @typedef {BaseMessageOptions} WebhookMessageEditOptions - * @property {Attachment[]} [attachments] Attachments to send with the message + * @typedef {MessageEditOptions} WebhookMessageEditOptions * @property {Snowflake} [threadId] The id of the thread this message belongs to * For interaction webhooks, this property is ignored */ diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts index 890629cda..6ef85e9bf 100644 --- a/packages/discord.js/typings/index.d.ts +++ b/packages/discord.js/typings/index.d.ts @@ -6506,10 +6506,7 @@ export interface InteractionCollectorOptions< export interface InteractionDeferReplyOptions { /** @deprecated Use {@link InteractionDeferReplyOptions.flags} instead. */ ephemeral?: boolean; - flags?: BitFieldResolvable< - Extract, - MessageFlags.Ephemeral | MessageFlags.SuppressEmbeds | MessageFlags.SuppressNotifications - >; + flags?: BitFieldResolvable, MessageFlags.Ephemeral>; withResponse?: boolean; /** @deprecated Use {@link InteractionDeferReplyOptions.withResponse} instead. */ fetchReply?: boolean; @@ -7240,7 +7237,7 @@ export interface WebhookEditOptions { reason?: string; } -export interface WebhookMessageEditOptions extends Omit { +export interface WebhookMessageEditOptions extends MessageEditOptions { threadId?: Snowflake; }