make fetching members way better (#1124)

* make fetching members way better

* fix up fetching edge cases yet again

* stop making useless collections

* Update Guild.js

* Update Guild.js

* consistency?

* Update GuildMembersChunk.js

* Update Guild.js

* Update Guild.js

* Open editor to fix issues instead of GH: check
This commit is contained in:
Gus Caplan
2017-05-21 15:09:37 -05:00
committed by Crawl
parent fce15ba33c
commit 694f8278f1
2 changed files with 13 additions and 17 deletions

View File

@@ -1,7 +1,6 @@
const AbstractHandler = require('./AbstractHandler');
const Constants = require('../../../../util/Constants');
// Uncomment in v12
// const Collection = require('../../../../util/Collection');
const Collection = require('../../../../util/Collection');
class GuildMembersChunkHandler extends AbstractHandler {
handle(packet) {
@@ -9,13 +8,9 @@ class GuildMembersChunkHandler extends AbstractHandler {
const data = packet.d;
const guild = client.guilds.get(data.guild_id);
if (!guild) return;
const members = new Collection();
// Uncomment in v12
// const members = new Collection();
//
// for (const member of data.members) members.set(member.id, guild._addMember(member, false));
const members = data.members.map(member => guild._addMember(member, false));
for (const member of data.members) members.set(member.id, guild._addMember(member, false));
client.emit(Constants.Events.GUILD_MEMBERS_CHUNK, members, guild);