From 6a42c5f92953b896bc6e74fe79bce796d1ae7849 Mon Sep 17 00:00:00 2001 From: Danial Raza Date: Wed, 15 Jan 2025 12:29:35 +0100 Subject: [PATCH] fix!: move `crosspost()` to `GuildMessageManager` (#10703) BREAKING CHANGE: The `crosspost()` method from `MessageManager` has been moved to `GuildMessageManager`. --- .../src/managers/GuildMessageManager.js | 15 +++++++++++++++ .../discord.js/src/managers/MessageManager.js | 13 ------------- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/packages/discord.js/src/managers/GuildMessageManager.js b/packages/discord.js/src/managers/GuildMessageManager.js index 7a93c99f1..0a69e1f33 100644 --- a/packages/discord.js/src/managers/GuildMessageManager.js +++ b/packages/discord.js/src/managers/GuildMessageManager.js @@ -1,6 +1,8 @@ 'use strict'; +const { Routes } = require('discord-api-types/v10'); const MessageManager = require('./MessageManager'); +const { DiscordjsTypeError, ErrorCodes } = require('../errors'); /** * Manages API methods for messages in a guild and holds their cache. @@ -12,6 +14,19 @@ class GuildMessageManager extends MessageManager { * @name GuildMessageManager#channel * @type {GuildTextBasedChannel} */ + + /** + * Publishes a message in an announcement channel to all channels following it, even if it's not cached. + * @param {MessageResolvable} message The message to publish + * @returns {Promise} + */ + async crosspost(message) { + const messageId = this.resolveId(message); + if (!messageId) throw new DiscordjsTypeError(ErrorCodes.InvalidType, 'message', 'MessageResolvable'); + + const data = await this.client.rest.post(Routes.channelMessageCrosspost(this.channel.id, messageId)); + return this.cache.get(data.id) ?? this._add(data); + } } module.exports = GuildMessageManager; diff --git a/packages/discord.js/src/managers/MessageManager.js b/packages/discord.js/src/managers/MessageManager.js index dcddf2857..60cec4f26 100644 --- a/packages/discord.js/src/managers/MessageManager.js +++ b/packages/discord.js/src/managers/MessageManager.js @@ -196,19 +196,6 @@ class MessageManager extends CachedManager { return this._add(d); } - /** - * Publishes a message in an announcement channel to all channels following it, even if it's not cached. - * @param {MessageResolvable} message The message to publish - * @returns {Promise} - */ - async crosspost(message) { - message = this.resolveId(message); - if (!message) throw new DiscordjsTypeError(ErrorCodes.InvalidType, 'message', 'MessageResolvable'); - - const data = await this.client.rest.post(Routes.channelMessageCrosspost(this.channel.id, message)); - return this.cache.get(data.id) ?? this._add(data); - } - /** * Pins a message to the channel's pinned messages, even if it's not cached. * @param {MessageResolvable} message The message to pin