refactor: fetch options consistency (#5824)

This commit is contained in:
ckohen
2021-06-12 04:10:35 -07:00
committed by GitHub
parent 08cffd6a30
commit 7111b4cd5f
10 changed files with 28 additions and 49 deletions

View File

@@ -73,8 +73,7 @@ class ChannelManager extends BaseManager {
/**
* Obtains a channel from Discord, or the channel cache if it's already available.
* @param {Snowflake} id ID of the channel
* @param {boolean} [cache=true] Whether to cache the new channel object if it isn't already
* @param {boolean} [force=false] Whether to skip the cache check and request the API
* @param {BaseFetchOptions} [options] Additional options for this fetch
* @returns {Promise<?Channel>}
* @example
* // Fetch a channel by its id
@@ -82,7 +81,7 @@ class ChannelManager extends BaseManager {
* .then(channel => console.log(channel.name))
* .catch(console.error);
*/
async fetch(id, cache = true, force = false) {
async fetch(id, { cache = true, force = false } = {}) {
if (!force) {
const existing = this.cache.get(id);
if (existing && !existing.partial) return existing;