Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-09 16:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(Shard): avoid caching null child in eval/fetchClientValue (#4823)

Browse Source
This commit is contained in:
Matt (IPv4) Cowley
2020-09-25 22:43:32 +01:00
committed by GitHub
parent 4e79e39e22
commit 77c0788b2c
2 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/sharding/Shard.js
View File

@@ -124,6 +124,9 @@ class Shard extends EventEmitter {
.on('exit', this._exitListener);
}
this._evals.clear();
this._fetches.clear();
/**
* Emitted upon the creation of the shard's child process/worker.
* @event Shard#spawn
@@ -225,6 +228,10 @@ class Shard extends EventEmitter {
* .catch(console.error);
*/
fetchClientValue(prop) {
// Shard is dead (maybe respawning), don't cache anything and error immediately
if (!this.process && !this.worker) return Promise.reject(new Error('SHARDING_NO_CHILD_EXISTS', this.id));
// Cached promise from previous call
if (this._fetches.has(prop)) return this._fetches.get(prop);
const promise = new Promise((resolve, reject) => {
@@ -255,6 +262,10 @@ class Shard extends EventEmitter {
* @returns {Promise<*>} Result of the script execution
*/
eval(script) {
// Shard is dead (maybe respawning), don't cache anything and error immediately
if (!this.process && !this.worker) return Promise.reject(new Error('SHARDING_NO_CHILD_EXISTS', this.id));
// Cached promise from previous call
if (this._evals.has(script)) return this._evals.get(script);
const promise = new Promise((resolve, reject) => {