From 7c0b6173dd6fd4bd98fe4986b4a4ef31d99b38bb Mon Sep 17 00:00:00 2001 From: Lewdcario Date: Wed, 18 Apr 2018 19:57:16 -0500 Subject: [PATCH] fix: Role#setPermissions resolving & docs --- src/client/rest/RESTMethods.js | 2 +- src/structures/Role.js | 2 +- src/util/Permissions.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/client/rest/RESTMethods.js b/src/client/rest/RESTMethods.js index 95da0e74a..f668e981b 100644 --- a/src/client/rest/RESTMethods.js +++ b/src/client/rest/RESTMethods.js @@ -632,7 +632,7 @@ class RESTMethods { data.hoist = typeof _data.hoist !== 'undefined' ? _data.hoist : role.hoist; data.mentionable = typeof _data.mentionable !== 'undefined' ? _data.mentionable : role.mentionable; - if (_data.permissions) data.permissions = Permissions.resolve(_data.permissions); + if (typeof _data.permissions !== 'undefined') data.permissions = Permissions.resolve(_data.permissions); else data.permissions = role.permissions; return this.rest.makeRequest('patch', Endpoints.Guild(role.guild).Role(role.id), true, data, undefined, reason) diff --git a/src/structures/Role.js b/src/structures/Role.js index b9ae2b9ac..3faf2fd3a 100644 --- a/src/structures/Role.js +++ b/src/structures/Role.js @@ -276,7 +276,7 @@ class Role { /** * Set the permissions of the role. - * @param {string[]} permissions The permissions of the role + * @param {PermissionResolvable|PermissionResolvable[]} permissions The permissions of the role * @param {string} [reason] Reason for changing the role's permissions * @returns {Promise} * @example diff --git a/src/util/Permissions.js b/src/util/Permissions.js index c2d604dbc..a69e547e7 100644 --- a/src/util/Permissions.js +++ b/src/util/Permissions.js @@ -165,7 +165,7 @@ class Permissions { static resolve(permission) { if (permission instanceof Array) return permission.map(p => this.resolve(p)).reduce((prev, p) => prev | p, 0); if (typeof permission === 'string') permission = this.FLAGS[permission]; - if (typeof permission !== 'number' || permission < 1) throw new RangeError(Constants.Errors.NOT_A_PERMISSION); + if (typeof permission !== 'number' || permission < 0) throw new RangeError(Constants.Errors.NOT_A_PERMISSION); return permission; } }