From 7ce6f2fc8a8756532d71a542186d10a0aa951471 Mon Sep 17 00:00:00 2001 From: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Fri, 29 Nov 2024 09:57:00 +0000 Subject: [PATCH] refactor(FetchApplicationCommandOptions): Use `Locale` over `LocaleString` (#10625) refactor(FetchApplicationCommandOptions): prefer `Locale` --- .../discord.js/src/managers/ApplicationCommandManager.js | 2 +- packages/discord.js/src/util/APITypes.js | 5 ----- packages/discord.js/typings/index.d.ts | 3 +-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/discord.js/src/managers/ApplicationCommandManager.js b/packages/discord.js/src/managers/ApplicationCommandManager.js index e38c2f7c8..8f6ce5310 100644 --- a/packages/discord.js/src/managers/ApplicationCommandManager.js +++ b/packages/discord.js/src/managers/ApplicationCommandManager.js @@ -82,7 +82,7 @@ class ApplicationCommandManager extends CachedManager { * Options used to fetch Application Commands from Discord * @typedef {BaseFetchOptions} FetchApplicationCommandOptions * @property {Snowflake} [guildId] The guild's id to fetch commands for, for when the guild is not cached - * @property {LocaleString} [locale] The locale to use when fetching this command + * @property {Locale} [locale] The locale to use when fetching this command * @property {boolean} [withLocalizations] Whether to fetch all localization data */ diff --git a/packages/discord.js/src/util/APITypes.js b/packages/discord.js/src/util/APITypes.js index 8b160aa6c..44f7f80ff 100644 --- a/packages/discord.js/src/util/APITypes.js +++ b/packages/discord.js/src/util/APITypes.js @@ -475,11 +475,6 @@ * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/Locale} */ -/** - * @external LocaleString - * @see {@link https://discord-api-types.dev/api/discord-api-types-v10#LocaleString} - */ - /** * @external MessageActivityType * @see {@link https://discord-api-types.dev/api/discord-api-types-v10/enum/MessageActivityType} diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts index 86cbe62df..f25f54221 100644 --- a/packages/discord.js/typings/index.d.ts +++ b/packages/discord.js/typings/index.d.ts @@ -126,7 +126,6 @@ import { APIEmbedImage, VideoQualityMode, LocalizationMap, - LocaleString, MessageActivityType, APIAttachment, APIChannel, @@ -5814,7 +5813,7 @@ export type EmojiResolvable = Snowflake | GuildEmoji | ReactionEmoji | Applicati export interface FetchApplicationCommandOptions extends BaseFetchOptions { guildId?: Snowflake; - locale?: LocaleString; + locale?: Locale; withLocalizations?: boolean; }