From 7db69780127f4e95ede7cd9066b513a903c08d23 Mon Sep 17 00:00:00 2001 From: Sugden <28943913+NotSugden@users.noreply.github.com> Date: Sat, 17 Oct 2020 14:40:23 +0100 Subject: [PATCH] fix(GuildMember): properly check permissions for hasPermissions (#4677) --- src/structures/GuildMember.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/structures/GuildMember.js b/src/structures/GuildMember.js index de4705ab4..05ca569e6 100644 --- a/src/structures/GuildMember.js +++ b/src/structures/GuildMember.js @@ -269,7 +269,8 @@ class GuildMember extends Base { */ hasPermission(permission, { checkAdmin = true, checkOwner = true } = {}) { if (checkOwner && this.user.id === this.guild.ownerID) return true; - return this.roles.cache.some(r => r.permissions.has(permission, checkAdmin)); + const permissions = new Permissions(this.roles.cache.map(role => role.permissions)); + return permissions.has(permission, checkAdmin); } /**