Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 11:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: compare with undefined directly (#9191)

Browse Source 
* refactor: compare with `undefined` directly

* fix: lint
This commit is contained in:
Almeida
2023-03-12 20:24:22 +00:00
committed by GitHub
parent 955e8fe312
commit 869153c3fd
29 changed files with 69 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/voice/src/DataStore.ts
View File

@@ -184,6 +184,6 @@ export function deleteAudioPlayer(player: AudioPlayer) {
audioPlayers.splice(index, 1);
if (audioPlayers.length === 0) {
nextTime = -1;
if (typeof audioCycleInterval !== 'undefined') clearTimeout(audioCycleInterval);
if (audioCycleInterval !== undefined) clearTimeout(audioCycleInterval);
}
}

4
packages/voice/src/VoiceConnection.ts
View File

@@ -354,8 +354,8 @@ export class VoiceConnection extends EventEmitter {
private addStatePacket(packet: GatewayVoiceStateUpdateDispatchData) {
this.packets.state = packet;
if (typeof packet.self_deaf !== 'undefined') this.joinConfig.selfDeaf = packet.self_deaf;
if (typeof packet.self_mute !== 'undefined') this.joinConfig.selfMute = packet.self_mute;
if (packet.self_deaf !== undefined) this.joinConfig.selfDeaf = packet.self_deaf;
if (packet.self_mute !== undefined) this.joinConfig.selfMute = packet.self_mute;
if (packet.channel_id) this.joinConfig.channelId = packet.channel_id;
/*
the channel_id being null doesn't necessarily mean it was intended for the client to leave the voice channel

2
packages/voice/src/audio/AudioResource.ts
View File

@@ -258,7 +258,7 @@ export function createAudioResource<T>(
// string inputs can only be used with FFmpeg
if (typeof input === 'string') {
inputType = StreamType.Arbitrary;
} else if (typeof inputType === 'undefined') {
} else if (inputType === undefined) {
const analysis = inferStreamType(input);
inputType = analysis.streamType;
needsInlineVolume = needsInlineVolume && !analysis.hasVolume;

2
packages/voice/src/networking/Networking.ts
View File

@@ -498,7 +498,7 @@ export class Networking extends EventEmitter {
public dispatchAudio() {
const state = this.state;
if (state.code !== NetworkingStatusCode.Ready) return false;
if (typeof state.preparedPacket !== 'undefined') {
if (state.preparedPacket !== undefined) {
this.playAudioPacket(state.preparedPacket);
state.preparedPacket = undefined;
return true;

2
packages/voice/src/networking/VoiceWebSocket.ts
View File

@@ -161,7 +161,7 @@ export class VoiceWebSocket extends EventEmitter {
* @param ms - The interval in milliseconds. If negative, the interval will be unset
*/
public setHeartbeatInterval(ms: number) {
if (typeof this.heartbeatInterval !== 'undefined') clearInterval(this.heartbeatInterval);
if (this.heartbeatInterval !== undefined) clearInterval(this.heartbeatInterval);
if (ms > 0) {
this.heartbeatInterval = setInterval(() => {
if (this.lastHeartbeatSend !== 0 && this.missedHeartbeats >= 3) {

2
packages/voice/src/receive/AudioReceiveStream.ts
View File

@@ -69,7 +69,7 @@ export class AudioReceiveStream extends Readable {
buffer &&
(this.end.behavior === EndBehaviorType.AfterInactivity ||
(this.end.behavior === EndBehaviorType.AfterSilence &&
(buffer.compare(SILENCE_FRAME) !== 0 || typeof this.endTimeout === 'undefined')))
(buffer.compare(SILENCE_FRAME) !== 0 || this.endTimeout === undefined)))
) {
this.renewEndTimeout(this.end);
}