Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-15 19:13:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: do not cache webhook users (#2611)

Browse Source 
Goal in mind is to not save the name and avatar used by webhooks because
those can change between messages without any other update.
This commit is contained in:
SpaceEEC
2018-06-21 21:34:30 +02:00
committed by GitHub
parent bd3d8d48c0
commit 8a3ae875bb
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/client/ClientDataManager.js
View File

@@ -39,10 +39,10 @@ class ClientDataManager {
return guild; return guild;
} }
newUser(data) { newUser(data, cache = true) {
if (this.client.users.has(data.id)) return this.client.users.get(data.id); if (this.client.users.has(data.id)) return this.client.users.get(data.id);
const user = new User(this.client, data); const user = new User(this.client, data);
this.client.users.set(user.id, user); if (cache) this.client.users.set(user.id, user);
return user; return user;
} }

2
src/structures/Message.js
View File

@@ -55,7 +55,7 @@ class Message {
* The author of the message * The author of the message
* @type {User} * @type {User}
*/ */
this.author = this.client.dataManager.newUser(data.author); this.author = this.client.dataManager.newUser(data.author, !data.webhook_id);
/** /**
* Represents the author of the message as a guild member * Represents the author of the message as a guild member