Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-16 11:33:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix bulk deletion error if < 2 messages

Browse Source 
Also return error if no server (dm)
This commit is contained in:
Manuel Kraus
2016-05-24 23:44:26 +02:00
parent fae03042cb
commit 8bee117445
3 changed files with 24 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Client/InternalClient.js
View File

@@ -849,7 +849,7 @@ var InternalClient = (function () {
InternalClient.prototype.deleteMessages = function deleteMessages(_messages) { InternalClient.prototype.deleteMessages = function deleteMessages(_messages) {
if (!_messages instanceof Array) return Promise.reject(new Error("Messages provided must be in an array")); if (!_messages instanceof Array) return Promise.reject(new Error("Messages provided must be in an array"));
if (_messages.length < 1) return Promise.reject(new Error("You must provide at least one message to delete")); if (_messages.length < 2) return Promise.reject(new Error("You must provide at least two messages to delete"));
var messages = []; var messages = [];
var channel; var channel;
@@ -870,6 +870,10 @@ var InternalClient = (function () {
var message = this.resolver.resolveMessage(_message); var message = this.resolver.resolveMessage(_message);
if (!message) return Promise.reject(new Error("Something other than a message could not be resolved in the array...")); if (!message) return Promise.reject(new Error("Something other than a message could not be resolved in the array..."));
if (!message.server) {
return Promise.reject(new Error("You can only bulk delete messages on guild channels"));
}
// ensure same channel // ensure same channel
if (!channel) { if (!channel) {
channel = message.channel; channel = message.channel;

24
lib/Util/TokenCacher-shim.js
View File

@@ -6,23 +6,23 @@ exports.__esModule = true;
function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } } function _classCallCheck(instance, Constructor) { if (!(instance instanceof Constructor)) { throw new TypeError("Cannot call a class as a function"); } }
var TokenCacher = (function () { var TokenCacher = (function () {
function TokenCacher() { function TokenCacher() {
_classCallCheck(this, TokenCacher); _classCallCheck(this, TokenCacher);
} }
TokenCacher.prototype.setToken = function setToken() {}; TokenCacher.prototype.setToken = function setToken() {};
TokenCacher.prototype.save = function save() {}; TokenCacher.prototype.save = function save() {};
TokenCacher.prototype.getToken = function getToken() { TokenCacher.prototype.getToken = function getToken() {
return null; return null;
}; };
TokenCacher.prototype.init = function init(ind) { TokenCacher.prototype.init = function init(ind) {
this.done = true; this.done = true;
}; };
return TokenCacher; return TokenCacher;
})(); })();
exports["default"] = TokenCacher; exports["default"] = TokenCacher;

9
src/Client/InternalClient.js
View File

@@ -701,8 +701,9 @@ export default class InternalClient {
deleteMessages(_messages) { deleteMessages(_messages) {
if (!_messages instanceof Array) if (!_messages instanceof Array)
return Promise.reject(new Error("Messages provided must be in an array")); return Promise.reject(new Error("Messages provided must be in an array"));
if (_messages.length < 1) if (_messages.length < 2)
return Promise.reject(new Error("You must provide at least one message to delete")) return Promise.reject(new Error("You must provide at least two messages to delete"));
var messages = []; var messages = [];
var channel; var channel;
@@ -711,6 +712,10 @@ export default class InternalClient {
if (!message) if (!message)
return Promise.reject(new Error("Something other than a message could not be resolved in the array...")); return Promise.reject(new Error("Something other than a message could not be resolved in the array..."));
if(!message.server) {
return Promise.reject(new Error("You can only bulk delete messages on guild channels"));
}
// ensure same channel // ensure same channel
if (!channel) { if (!channel) {
channel = message.channel; channel = message.channel;