From 8ccae833e70782a39f4262de7b0e624978df86fb Mon Sep 17 00:00:00 2001 From: Aryan Bagade <73382554+AryanBagade@users.noreply.github.com> Date: Fri, 2 Jan 2026 09:56:34 -0800 Subject: [PATCH] types(UserManager): fix send() return type to Promise> (#11337) * types(UserManager): fix send() return type to Promise> UserManager.send() always sends a direct message (DM), so the return type should b Promise> instead of Promise to correctly indicate that the message is not in a guild context. Closes #11331 * fix: requested changes --------- Co-authored-by: almeidx Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> --- packages/discord.js/typings/index.d.ts | 2 +- packages/discord.js/typings/index.test-d.ts | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/discord.js/typings/index.d.ts b/packages/discord.js/typings/index.d.ts index ff51d0c6c..8db068601 100644 --- a/packages/discord.js/typings/index.d.ts +++ b/packages/discord.js/typings/index.d.ts @@ -4801,7 +4801,7 @@ export class UserManager extends CachedManager public createDM(user: UserResolvable, options?: BaseFetchOptions): Promise; public deleteDM(user: UserResolvable): Promise; public fetch(user: UserResolvable, options?: BaseFetchOptions): Promise; - public send(user: UserResolvable, options: MessageCreateOptions | MessagePayload | string): Promise; + public send(user: UserResolvable, options: MessageCreateOptions | MessagePayload | string): Promise>; } export class VoiceStateManager extends CachedManager { diff --git a/packages/discord.js/typings/index.test-d.ts b/packages/discord.js/typings/index.test-d.ts index 71aeb858a..86d8b5760 100644 --- a/packages/discord.js/typings/index.test-d.ts +++ b/packages/discord.js/typings/index.test-d.ts @@ -1534,6 +1534,8 @@ expectType['send']>(voiceChannel.send); expectAssignable(user); expectAssignable(guildMember); +expectType>>(client.users.send(user, 'test')); + expectType>(textChannel.setType(ChannelType.GuildAnnouncement)); expectType>(announcementChannel.setType(ChannelType.GuildText));