From c9faa15ac753b7c336ca74f13a304f4ff2f47163 Mon Sep 17 00:00:00 2001 From: Simon Schick Date: Fri, 11 Dec 2015 00:55:34 +0100 Subject: [PATCH] Simplified code segment, removed pointless concat call. --- src/Client/InternalClient.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/Client/InternalClient.js b/src/Client/InternalClient.js index 84f5c5a09..d5d9df1f5 100644 --- a/src/Client/InternalClient.js +++ b/src/Client/InternalClient.js @@ -597,11 +597,8 @@ export default class InternalClient { var roleIDS = roles[0].server.memberMap[member.id].roles.map(r => r.id); - for(var role of roles) { - if (!role.server.memberMap[member.id]) { - return Promise.reject(new Error("member not in server")); - } - roleIDS.concat(role.id); + if(roles.any(role => !role.server.memberMap[member.id])) { + return Promise.reject(new Error("Role does not exist on same server as member")); } return this.apiRequest(