Nomchy/discord.js
1
0
Fork 0
mirror of https://github.com/discordjs/discord.js.git synced 2026-03-14 18:43:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(Guild): memberCount not decrementing when an uncached member leaves

Browse Source 
This leads to GuildMemberStore#_fetchMany to always reject
because it expects more member than possible.

Also no longer call the GuildMemberRemove handler locally
to not decrement twice.
This commit is contained in:
Pascal
2018-01-21 07:30:59 +01:00
parent 986e6da196
commit 93e083da4f
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/client/actions/GuildMemberRemove.js
View File

@@ -8,8 +8,8 @@ class GuildMemberRemoveAction extends Action {
let member = null; let member = null;
if (guild) { if (guild) {
member = guild.members.get(data.user.id); member = guild.members.get(data.user.id);
guild.memberCount--;
if (member) { if (member) {
guild.memberCount--;
guild.members.remove(member.id); guild.members.remove(member.id);
if (client.status === Status.READY) client.emit(Events.GUILD_MEMBER_REMOVE, member); if (client.status === Status.READY) client.emit(Events.GUILD_MEMBER_REMOVE, member);
} }

7
src/structures/GuildMember.js
View File

@@ -526,12 +526,7 @@ class GuildMember extends Base {
*/ */
kick(reason) { kick(reason) {
return this.client.api.guilds(this.guild.id).members(this.user.id).delete({ reason }) return this.client.api.guilds(this.guild.id).members(this.user.id).delete({ reason })
.then(() => .then(() => this);
this.client.actions.GuildMemberRemove.handle({
guild_id: this.guild.id,
user: this.user,
}).member
);
} }
/** /**