cleanup(GuildMember{RoleStore}): Rewrite to async/await (#3072)

- Fixed a bug where `GuildMemberRoleStore#{add,remove}` would create a rejected promise inside a promise, instead of rejecting the first one.
- Fixed a bug where `GuildMember#edit` with a specified unknown channel would throw synchronously, instead of rejecting asynchronously.
This commit is contained in:
Kyra
2019-02-09 18:20:10 +01:00
committed by Amish Shah
parent c432591113
commit 9449f8df8f
2 changed files with 15 additions and 15 deletions

View File

@@ -248,7 +248,7 @@ class GuildMember extends Base {
* @param {string} [reason] Reason for editing this user
* @returns {Promise<GuildMember>}
*/
edit(data, reason) {
async edit(data, reason) {
if (data.channel) {
data.channel = this.guild.channels.resolve(data.channel);
if (!data.channel || data.channel.type !== 'voice') {
@@ -266,12 +266,12 @@ class GuildMember extends Base {
} else {
endpoint = endpoint.members(this.id);
}
return endpoint.patch({ data, reason }).then(() => {
const clone = this._clone();
data.user = this.user;
clone._patch(data);
return clone;
});
await endpoint.patch({ data, reason });
const clone = this._clone();
data.user = this.user;
clone._patch(data);
return clone;
}
/**