From 94bb2686396ce97b50015b0fa34a6c27528afdbd Mon Sep 17 00:00:00 2001 From: Androz Date: Wed, 12 Feb 2020 18:36:08 +0100 Subject: [PATCH] docs: add extends to ChannelManager, cache is not nullable, resolveID accepts an object (#3771) * Add extends to docs * Cache shouldn't be nullable * jsdoc: use same type for both resolve methods --- src/managers/BaseManager.js | 4 ++-- src/managers/ChannelManager.js | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/managers/BaseManager.js b/src/managers/BaseManager.js index b9d0be938..ae07ee62f 100644 --- a/src/managers/BaseManager.js +++ b/src/managers/BaseManager.js @@ -35,7 +35,7 @@ class BaseManager { /** * Holds the cache for the data model - * @type {?Collection} + * @type {Collection} */ this.cache = new cacheType(...cacheOptions); if (iterable) for (const i of iterable) this.add(i); @@ -64,7 +64,7 @@ class BaseManager { /** * Resolves a data entry to a instance ID. - * @param {string|Instance} idOrInstance The id or instance of something in this Manager + * @param {string|Object} idOrInstance The id or instance of something in this Manager * @returns {?Snowflake} */ resolveID(idOrInstance) { diff --git a/src/managers/ChannelManager.js b/src/managers/ChannelManager.js index b47667e54..e85330440 100644 --- a/src/managers/ChannelManager.js +++ b/src/managers/ChannelManager.js @@ -6,6 +6,7 @@ const { Events } = require('../util/Constants'); /** * A manager of channels belonging to a client + * @extends {BaseManager} */ class ChannelManager extends BaseManager { constructor(client, iterable) {