From 98dc2df6d4c662d93f2db564f16c4aa4f861a920 Mon Sep 17 00:00:00 2001 From: Amish Shah Date: Tue, 7 Aug 2018 19:08:27 +0100 Subject: [PATCH] Revert "fix(Collection): use `new this.constructor` instead of `new Collection` (#2709)" This reverts commit c10b4feeeb7705903593ba134df128c57a823ff1. --- src/util/Collection.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/Collection.js b/src/util/Collection.js index f8ac733ad..06f54f59c 100644 --- a/src/util/Collection.js +++ b/src/util/Collection.js @@ -220,7 +220,7 @@ class Collection extends Map { */ filter(fn, thisArg) { if (typeof thisArg !== 'undefined') fn = fn.bind(thisArg); - const results = new this.constructor(); + const results = new Collection(); for (const [key, val] of this) { if (fn(val, key, this)) results.set(key, val); } @@ -237,7 +237,7 @@ class Collection extends Map { */ partition(fn, thisArg) { if (typeof thisArg !== 'undefined') fn = fn.bind(thisArg); - const results = [new this.constructor(), new this.constructor()]; + const results = [new Collection(), new Collection()]; for (const [key, val] of this) { if (fn(val, key, this)) { results[0].set(key, val); @@ -404,7 +404,7 @@ class Collection extends Map { * @example collection.sort((userA, userB) => userA.createdTimestamp - userB.createdTimestamp); */ sort(compareFunction = (x, y) => +(x > y) || +(x === y) - 1) { - return new this.constructor([...this.entries()].sort((a, b) => compareFunction(a[1], b[1], a[0], b[0]))); + return new Collection([...this.entries()].sort((a, b) => compareFunction(a[1], b[1], a[0], b[0]))); } toJSON() {