From 9b41a6a8a62331250f0787843c646fcb7f4aeb04 Mon Sep 17 00:00:00 2001 From: Lewdcario Date: Thu, 1 Mar 2018 11:52:29 -0600 Subject: [PATCH] fix: re-add highest property to RoleStore and GuildMemberRoleStore closes #2302 --- src/stores/GuildMemberRoleStore.js | 2 +- src/stores/RoleStore.js | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/stores/GuildMemberRoleStore.js b/src/stores/GuildMemberRoleStore.js index af9d08ef1..eb0096554 100644 --- a/src/stores/GuildMemberRoleStore.js +++ b/src/stores/GuildMemberRoleStore.js @@ -106,7 +106,7 @@ class GuildMemberRoleStore extends DataStore { * @readonly */ get highest() { - return this.reduce((prev, role) => !prev || role.comparePositionTo(prev) > 0 ? role : prev); + return this.reduce((prev, role) => role.comparePositionTo(prev) > 0 ? role : prev, this.first()); } /** diff --git a/src/stores/RoleStore.js b/src/stores/RoleStore.js index 5619360e2..c2878968c 100644 --- a/src/stores/RoleStore.js +++ b/src/stores/RoleStore.js @@ -55,6 +55,15 @@ class RoleStore extends DataStore { }); } + /** + * The role with the highest position in the store + * @type {Role} + * @readonly + */ + get highest() { + return this.reduce((prev, role) => role.comparePositionTo(prev) > 0 ? role : prev, this.first()); + } + /** * Data that can be resolved to a Role object. This can be: * * A Role