refactor: more oop with stores (#2216)

* refactor: more oop with stores

* forgot bulk delete

* Revert "forgot bulk delete"

This reverts commit 1b4fb999ee07b358ee6e1af9efb8981b84f83af1.

* appease linter

* missed some


shh

* fail

src/client/actions/ChannelCreate.js

@@ -5,7 +5,7 @@ class ChannelCreateAction extends Action {
   handle(data) {
     const client = this.client;
     const existing = client.channels.has(data.id);
-    const channel = client.channels.create(data);
+    const channel = client.channels.add(data);
     if (!existing && channel) {
       client.emit(Events.CHANNEL_CREATE, channel);
     }

src/client/actions/GuildBanRemove.js

@@ -5,7 +5,7 @@ class GuildBanRemove extends Action {
   handle(data) {
     const client = this.client;
     const guild = client.guilds.get(data.guild_id);
-    const user = client.users.create(data.user);
+    const user = client.users.add(data.user);
     if (guild && user) client.emit(Events.GUILD_BAN_REMOVE, guild, user);
   }
 }

src/client/actions/GuildEmojiCreate.js

@@ -3,7 +3,7 @@ const { Events } = require('../../util/Constants');
 
 class GuildEmojiCreateAction extends Action {
   handle(guild, createdEmoji) {
-    const emoji = guild.emojis.create(createdEmoji);
+    const emoji = guild.emojis.add(createdEmoji);
     this.client.emit(Events.GUILD_EMOJI_CREATE, emoji);
     return { emoji };
   }

src/client/actions/GuildRoleCreate.js

@@ -8,7 +8,7 @@ class GuildRoleCreate extends Action {
     let role;
     if (guild) {
       const already = guild.roles.has(data.role.id);
-      role = guild.roles.create(data.role);
+      role = guild.roles.add(data.role);
       if (!already) client.emit(Events.GUILD_ROLE_CREATE, role);
     }
     return { role };

src/client/actions/GuildSync.js

@@ -7,7 +7,7 @@ class GuildSync extends Action {
     const guild = client.guilds.get(data.id);
     if (guild) {
       if (data.presences) {
-        for (const presence of data.presences) guild.presences.create(presence);
+        for (const presence of data.presences) guild.presences.add(presence);
       }
 
       if (data.members) {
@@ -16,7 +16,7 @@ class GuildSync extends Action {
           if (member) {
             member._patch(syncMember);
           } else {
-            guild.members.create(syncMember, false);
+            guild.members.add(syncMember, false);
           }
         }
       }

src/client/actions/MessageCreate.js

@@ -8,7 +8,7 @@ class MessageCreateAction extends Action {
     if (channel) {
       const existing = channel.messages.get(data.id);
       if (existing) return { message: existing };
-      const message = channel.messages.create(data);
+      const message = channel.messages.add(data);
       const user = message.author;
       const member = channel.guild ? channel.guild.member(user) : null;
       channel.lastMessageID = data.id;

src/client/actions/MessageReactionAdd.js

@@ -19,7 +19,7 @@ class MessageReactionAdd extends Action {
     if (!message) return false;
     if (!data.emoji) return false;
     // Verify reaction
-    const reaction = message.reactions.create({
+    const reaction = message.reactions.add({
       emoji: data.emoji,
       count: 0,
       me: user.id === this.client.user.id,