From a359f344d891e0166ed18f49c61a84d0ea4f99cd Mon Sep 17 00:00:00 2001 From: Steffen Date: Sun, 13 Nov 2016 08:07:51 +0100 Subject: [PATCH] UnhandledPromiseRejectionWarning caused by resolveBuffer on empty resource body (#886) * Fix for UnhandledPromiseRejectionWarning in resolveBuffer * code simplification * reject with TypeError if body is not a Buffer --- src/client/ClientDataResolver.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/client/ClientDataResolver.js b/src/client/ClientDataResolver.js index 76fa85a8d..11f7ef23e 100644 --- a/src/client/ClientDataResolver.js +++ b/src/client/ClientDataResolver.js @@ -244,7 +244,11 @@ class ClientDataResolver { if (/^https?:\/\//.test(resource)) { request.get(resource) .set('Content-Type', 'blob') - .end((err, res) => err ? reject(err) : resolve(res.body)); + .end((err, res) => { + if (err) return reject(err); + if (!(res.body instanceof Buffer)) return reject(new TypeError('Body is not a Buffer')); + return resolve(res.body); + }); } else { const file = path.resolve(resource); fs.stat(file, (err, stats) => {