From a652901d60a7ecb7ce8f77cbb9d1210f049e9e59 Mon Sep 17 00:00:00 2001 From: Isabella Date: Wed, 19 Apr 2017 11:57:54 -0500 Subject: [PATCH] Throw Error for non role-resolvables (#1322) * throw error for role names/integers being provided for role resolvables * Update RESTMethods.js * Update RESTMethods.js im really bad * Update RESTMethods.js * removed new promise reject ty gus * Update RESTMethods.js * move error to guildmember.addRole method * Update GuildMember.js --- src/structures/GuildMember.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/structures/GuildMember.js b/src/structures/GuildMember.js index 09dae24b3..3785290eb 100644 --- a/src/structures/GuildMember.js +++ b/src/structures/GuildMember.js @@ -393,6 +393,7 @@ class GuildMember { */ addRole(role) { if (!(role instanceof Role)) role = this.guild.roles.get(role); + if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.'); return this.client.rest.methods.addMemberRole(this, role); } @@ -419,6 +420,7 @@ class GuildMember { */ removeRole(role) { if (!(role instanceof Role)) role = this.guild.roles.get(role); + if (!role) throw new TypeError('Supplied parameter was neither a Role nor a Snowflake.'); return this.client.rest.methods.removeMemberRole(this, role); }